ID:               40109
 User updated by:  kevin dot burek at gmail dot com
 Reported By:      kevin dot burek at gmail dot com
 Status:           Open
 Bug Type:         *Graphics related
 Operating System: all
 PHP Version:      All
 New Comment:

here's a diff for 5.2.0 that should patch many of the cases that this
bug manifests:

183c183
<       unsigned int spool = 0, done = 0, inx, len;     
---
>       unsigned int spool = 0, done = 0, written=0, inx, len;  
266a267,268
>                       case M_APP1:
>                               /* APP1 (EXIF) usually appears in lieu of a 
> missing APP0 (JFIF)
*/ 
268a271
>                               if (written) break; /* it seems we've already 
> written our header
*/
281a285
>                               written = 1;


Previous Comments:
------------------------------------------------------------------------

[2007-01-12 07:33:02] kevin dot burek at gmail dot com

Tested in newest build and problem persists.

------------------------------------------------------------------------

[2007-01-12 06:44:15] kevin dot burek at gmail dot com

Description:
------------
The poorly documented iptcembed function fails to insert a header (and
throws no errors) when a jpeg lacks the APP0 marker.  The code in
iptc.c is currently written to insert the new APP13 section immediately
after the APP0 section.  When this is missing, the function falls
straight through.

Reproduce code:
---------------
http://www.php.net/manual/en/function.iptcembed.php#18549

Expected result:
----------------
Image with new iptc data inserted at APP13 marker

Actual result:
--------------
Image copied, yet stripped of old iptc data


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=40109&edit=1

Reply via email to