In this case i would vote for RETURN_NULL(); instead
of simply using return;
At 20:20 04.10.2002, Markus Fischer wrote:
> No function never called RETURN_FALSE if
> zend_parse_parameters couldn't successfully parse the passed
> parameters.
>
> Are we going to change this behaviour globally?
>
> Function up and including today returned NULL if there was a
> problem with parsing the parameters.
>
> This could well break BC in my eyes. Is this absolutely
> necessary ?
>
>On Fri, Oct 04, 2002 at 05:17:01PM -0000, Marcus Börger wrote :
> > helly Fri Oct 4 13:17:01 2002 EDT
> >
> > Modified files:
> > /php4/ext/standard basic_functions.c
> > Log:
> > return FALSE on error
> >
> >
> > Index: php4/ext/standard/basic_functions.c
> > diff -u php4/ext/standard/basic_functions.c:1.522
> php4/ext/standard/basic_functions.c:1.523
> > --- php4/ext/standard/basic_functions.c:1.522 Thu Oct 3 09:31:59 2002
> > +++ php4/ext/standard/basic_functions.c Fri Oct 4 13:17:01 2002
> > @@ -17,7 +17,7 @@
> >
> +----------------------------------------------------------------------+
> > */
> >
> > -/* $Id: basic_functions.c,v 1.522 2002/10/03 13:31:59 yohgaki Exp $ */
> > +/* $Id: basic_functions.c,v 1.523 2002/10/04 17:17:01 helly Exp $ */
> >
> > #include "php.h"
> > #include "php_streams.h"
> > @@ -1377,7 +1377,7 @@
> >
> > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s",
> > &options,
> &options_len) == FAILURE) {
> > - return;
> > + RETURN_FALSE;
>[...]
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
