Ilia, the memory leak was in ext/xlst/sablot.c:1728 -> error_print. If there are problems accross platforms we should address that in the output, but this isn't testing that function.
On the other hand it's in general error handling. It's required to free the previous error, when registering a new one, which is easily forgotten, so maybe the test should test various ways of forcing multiple errors and then print them one way or the other. It would make the output too complex and platform dependant, so it should probably use ob_get_contents and 'grep' for Memory Leak? At 04:40 24-10-2002, Ilia Alshanetsky wrote:
iliaa Wed Oct 23 22:40:02 2002 EDT
Modified files:
/php4/ext/xslt/tests 009.phpt
Log:
Various corrections aimed at making the test's results consistent across
all enviroments.
Index: php4/ext/xslt/tests/009.phpt
diff -u php4/ext/xslt/tests/009.phpt:1.3 php4/ext/xslt/tests/009.phpt:1.4
--- php4/ext/xslt/tests/009.phpt:1.3 Wed Oct 23 18:21:39 2002
+++ php4/ext/xslt/tests/009.phpt Wed Oct 23 22:40:02 2002
@@ -2,17 +2,20 @@
Memoryleak in error printing
--SKIPIF--
<?php include("skipif.inc"); ?>
+--INI--
+error_reporting=2047
+display_errors=0
+track_errors=1
--FILE--
<?php
-error_reporting(E_ALL);
$xmlfile = 'ext/xslt/tests/non-existent.xml';
$xslfile = 'ext/xslt/tests/non-existent.xsl';
$xh = xslt_create();
$result = xslt_process($xh, $xmlfile, $xslfile, NULL);
xslt_free($xh);
+
+echo $php_errormsg."\n";
?>
--EXPECTF--
-Warning: Sablotron error on line none: cannot open file '%s/ext/xslt/tests/non-existent.xsl' in %s/ext/xslt/tests/009.%s on line %i
-
-%sext/xslt/tests/009.%s(%i) : Warning - Sablotron error on line none: cannot open file '%sext/xslt/tests/non-existent.xsl'
+Sablotron error on line none: cannot open file '%s/ext/xslt/tests/non-existent.xsl'
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
