On November 14, 2002 10:45 am, Marcus Börger wrote:
> I always compile with all warnings enabled and fix warnings for
> linux and windows builds.
>
> I am mostly using gcc -Wall -Wconversion -ggdb
Thanks, I'll add -Wconversion to my CFLAGS.
> [marcus@zaphod PHP_4_3_0]$ gcc -v
> Reading specs from /usr/lib/gcc-lib/i586-mandrake-linux-gnu/2.96/specs
> gcc version 2.96 20000731 (Mandrake Linux 8.2 2.96-0.76mdk)
>
> Sometimes i use a sun as well but i am not fixing warnings for that target.
>
> The warning was about pxlLeft propably not bein initialised.
> This could not happen if every thing is ok. If not Setting it to 0
> should result in something debugable.
I've tried the fix on the regular gcc 2.95.3 and gcc 3.2 (Sun OS) both did not
complain with the regular -Wall -g3 flags.
> Or do you mean the other fix for the TSRM stuff?
My mistake, I usually don't compile with TSRM since some modules do not
compile when I use experimental-zts.
Ilia
> marcus
>
> At 16:27 14.11.2002, Ilia A. wrote:
> >Which compiler are you using and with which options that gave you
> > warning(s) on these lines?
> >
> >Ilia
> >
> >On November 14, 2002 10:08 am, Marcus Boerger wrote:
> > > helly Thu Nov 14 10:08:40 2002 EDT
> > >
> > > Modified files:
> > > /php4/ext/gd/libgd gd.c
> > > Log:
> > > Fix warnings (Marcus & Pierre-Alain Joye)
> > >
> > >
> > > Index: php4/ext/gd/libgd/gd.c
> > > diff -u php4/ext/gd/libgd/gd.c:1.25 php4/ext/gd/libgd/gd.c:1.26
> > > --- php4/ext/gd/libgd/gd.c:1.25 Wed Nov 13 15:02:58 2002
> > > +++ php4/ext/gd/libgd/gd.c Thu Nov 14 10:08:39 2002
> > > @@ -2215,7 +2215,7 @@
> > > int i, r, g, b, a;
> > > FuncPtr f;
> > >
> > > - int pxlOldLeft, pxlLeft, pxlSrc;
> > > + int pxlOldLeft, pxlLeft=0, pxlSrc;
> > >
> > > if (src->trueColor) {
> > > f = gdImageGetTrueColorPixel;
> > > @@ -2301,7 +2301,7 @@
> > > typedef int (*FuncPtr)(gdImagePtr, int, int);
> > > int i, iYPos=0, r, g, b, a;
> > > FuncPtr f;
> > > - int pxlOldLeft, pxlLeft, pxlSrc;
> > > + int pxlOldLeft, pxlLeft=0, pxlSrc;
> > >
> > > if (src->trueColor) {
> > > f = gdImageGetTrueColorPixel;
> >
> >--
> >PHP CVS Mailing List (http://www.php.net/)
> >To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
