On Tue, 19 Nov 2002, George Schlossnagle wrote:
>gschlossnagle Mon Nov 18 20:20:42 2002 EDT
>
> Modified files:
> /php4/sapi/apache_hooks config.m4
> Log:
> now this works (thanks Rasmus)
> Note: the correct line is --with-apache-hooks
>
>
>Index: php4/sapi/apache_hooks/config.m4
>diff -u php4/sapi/apache_hooks/config.m4:1.1 php4/sapi/apache_hooks/config.m4:1.2
>--- php4/sapi/apache_hooks/config.m4:1.1 Sun Nov 17 20:01:21 2002
>+++ php4/sapi/apache_hooks/config.m4 Mon Nov 18 20:20:42 2002
>@@ -1,10 +1,10 @@
> dnl
>-dnl $Id: config.m4,v 1.1 2002/11/18 01:01:21 gschlossnagle Exp $
>+dnl $Id: config.m4,v 1.2 2002/11/19 01:20:42 gschlossnagle Exp $
> dnl
>
> AC_MSG_CHECKING(for Apache 1.x module support via DSO through APXS)
>-AC_ARG_WITH(apache_hooks,
>-[ --with-apache_hooks[=FILE] Build shared Apache 1.x module. FILE is the
>optional
>+AC_ARG_WITH(apache-hooks,
>+[ --with-apache-hooks[=FILE] Build shared Apache 1.x module. FILE is the
>optional
> pathname to the Apache apxs tool; defaults to "apxs".],[
> if test "$withval" = "yes"; then
> APXS=apxs
>@@ -14,6 +14,7 @@
> APXS=/usr/sbin/apxs
> fi
> else
>+ AC_DEFINE(APACHE_HOOKS,1,[ ])
> PHP_EXPAND_PATH($withval, APXS)
> fi
>
>@@ -89,8 +90,9 @@
> if test "$PHP_SAPI" != "apache_hooks"; then
> AC_MSG_CHECKING(for Apache 1.x module support)
> AC_ARG_WITH(apache,
>-[ --with-apache_hooks_static[=DIR] Build Apache 1.x module. DIR is the
>top-level Apache
>+[ --with-apache_hooks-static[=DIR] Build Apache 1.x module. DIR is the
>top-level Apache
> build directory, defaults to /usr/local/apache.],[
>+ AC_DEFINE(APACHE_HOOKS,1,[ ])
I don't think this is correct either.. :)
It should be '--with-apache-hooks-static' and the
AC_ARG_WITH(apache-hooks-static...
And please change the help texts to explain the difference to normal apache builds.
(you can't have both, right? :)
--Jani
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
