This is useless if you don't test that the passed path is also valid. 
    ( $withval )
    
    And can't that library be compiled as shared too..?
    
    --Jani
    

On Sun, 1 Dec 2002, Harald Radi wrote:

>phanto         Sun Dec  1 08:44:22 2002 EDT
>
>  Modified files:              
>    /php4/sapi/milter  config.m4 
>  Log:
>  check for libmilter path
>  
>  
>Index: php4/sapi/milter/config.m4
>diff -u php4/sapi/milter/config.m4:1.4 php4/sapi/milter/config.m4:1.5
>--- php4/sapi/milter/config.m4:1.4     Sun Dec  1 08:36:53 2002
>+++ php4/sapi/milter/config.m4 Sun Dec  1 08:44:22 2002
>@@ -1,17 +1,19 @@
> dnl
>-dnl $Id: config.m4,v 1.4 2002/12/01 13:36:53 phanto Exp $
>+dnl $Id: config.m4,v 1.5 2002/12/01 13:44:22 phanto Exp $
> dnl
> 
> AC_MSG_CHECKING(for Milter support)
> AC_ARG_WITH(milter,
> [  --with-milter=DIR       Build PHP as Milter application],[
>   if test "$withval" = "yes"; then
>-    if test -f /usr/lib/libmilter.a; then
>+    if test -f /usr/lib/libmilter.a ; then
>       MILTERPATH=/usr/lib
>-    else if test -f /usr/lib/libmilter/libmilter.a; then
>-      MILTERPATH=/usr/lib/libmilter
>     else
>-      AC_MSG_ERROR(Unable to find libmilter.a)
>+      if test -f /usr/lib/libmilter/libmilter.a ; then
>+        MILTERPATH=/usr/lib/libmilter
>+      else
>+        AC_MSG_ERROR(Unable to find libmilter.a)
>+      fi
>     fi
>   else
>     MILTERPATH=$withval
>
>
>
>

-- 
<- For Sale! ->


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to