Yes, please revert.
--Wez.
On Sun, 2 Mar 2003, Moriyoshi Koizumi wrote:
> Hmm, now I figured out the compile failure occurred because I forgot to
> reconfigure after cvs update. However before my patching the code was
>
> if (textaddr) {
> #if HAVE_IPV6 && HAVE_INET_NTOP
> char abuf[256];
> #endif
>
> [snip]
>
> #if HAVE_IPV6
> case AF_INET6:
> buf = (char*)inet_ntop(sa->sa_family, &((struct sockaddr_in6*)sa
> )->sin6_addr, (char *)&abuf, sizeof(abuf));
>
> So I thought some patch was necessary there. Should I revert that?
>
> Moriyoshi
>
> Wez Furlong <[EMAIL PROTECTED]> wrote:
>
> > Does that really fix it?
> >
> > If you have IPV6 but no inet_ntop, then there is no way to determine the
> > socket/peer name.
> >
> > I'd rather the build broke in that situation and prompt someone with
> > such a strange system to add the correct code to tranform an ipv6
> > address into a human readable form.
> >
> > --Wez.
> >
> > On Sat, 1 Mar 2003, Moriyoshi Koizumi wrote:
> >
> > > moriyoshi Sat Mar 1 10:49:06 2003 EDT
> > >
> > > Modified files:
> > > /php4/main network.c
> > > Log:
> > > Fixed build
> > >
> > >
> > > Index: php4/main/network.c
> > > diff -u php4/main/network.c:1.95 php4/main/network.c:1.96
> > > --- php4/main/network.c:1.95 Fri Feb 28 16:03:36 2003
> > > +++ php4/main/network.c Sat Mar 1 10:49:06 2003
> > > @@ -17,7 +17,7 @@
> > > +----------------------------------------------------------------------+
> > > */
> > >
> > > -/* $Id: network.c,v 1.95 2003/02/28 21:03:36 wez Exp $ */
> > > +/* $Id: network.c,v 1.96 2003/03/01 15:49:06 moriyoshi Exp $ */
> > >
> > > /*#define DEBUG_MAIN_NETWORK 1*/
> > >
> > > @@ -509,7 +509,7 @@
> > >
> > > break;
> > >
> > > -#if HAVE_IPV6
> > > +#if HAVE_IPV6 && HAVE_INET_NTOP
> > > case AF_INET6:
> > > buf = (char*)inet_ntop(sa->sa_family, &((struct
> > > sockaddr_in6*)sa)->sin6_addr, (char *)&abuf, sizeof(abuf));
> > > if (buf) {
> > >
> > >
> > >
> > > --
> > > PHP CVS Mailing List (http://www.php.net/)
> > > To unsubscribe, visit: http://www.php.net/unsub.php
> > >
> > >
> > >
> >
>
>
>
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
