On Wed, 2 Apr 2003, Rasmus Lerdorf wrote:
>Oh, give me a break Jani. A space here or there makes absolutely no
>difference to the readability of the code, but all these whitespace
>commits get in the way of any real work when trying to track down problems
>via cvs diffs.
If you had committed correct style code in the first place,
I wouldn't have to make the 2nd commit on it. Hence the note
about not committing code like that anymore.
--Jani
>On Thu, 3 Apr 2003, Jani Taskinen wrote:
>
>> sniper Wed Apr 2 20:16:34 2003 EDT
>>
>> Modified files:
>> /php4/ext/bcmath bcmath.c
>> Log:
>> Another CS fix.
>> # Rasmus, at least try keep the style consistent..
>>
>>
>> Index: php4/ext/bcmath/bcmath.c
>> diff -u php4/ext/bcmath/bcmath.c:1.53 php4/ext/bcmath/bcmath.c:1.54
>> --- php4/ext/bcmath/bcmath.c:1.53 Wed Apr 2 18:51:52 2003
>> +++ php4/ext/bcmath/bcmath.c Wed Apr 2 20:16:34 2003
>> @@ -16,7 +16,7 @@
>> +----------------------------------------------------------------------+
>> */
>>
>> -/* $Id: bcmath.c,v 1.53 2003/04/02 23:51:52 rasmus Exp $ */
>> +/* $Id: bcmath.c,v 1.54 2003/04/03 01:16:34 sniper Exp $ */
>>
>> #ifdef HAVE_CONFIG_H
>> #include "config.h"
>> @@ -97,7 +97,11 @@
>> if (cfg_get_long("bcmath.scale", &bc_precision) == FAILURE) {
>> bc_precision = 0;
>> }
>> - if(bc_precision<0) bc_precision=0;
>> +
>> + if (bc_precision < 0) {
>> + bc_precision = 0;
>> + }
>> +
>> bc_init_numbers(TSRMLS_C);
>>
>> return SUCCESS;
>> @@ -145,7 +149,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -191,7 +195,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -237,7 +241,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -283,7 +287,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -296,7 +300,7 @@
>> bc_init_num(&result TSRMLS_CC);
>> php_str2num(&first, Z_STRVAL_PP(left) TSRMLS_CC);
>> php_str2num(&second, Z_STRVAL_PP(right) TSRMLS_CC);
>> - switch (bc_divide (first, second, &result, scale TSRMLS_CC)) {
>> + switch (bc_divide(first, second, &result, scale TSRMLS_CC)) {
>> case 0: /* OK */
>> if (result->n_scale > scale) {
>> result->n_scale = scale;
>> @@ -411,7 +415,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -457,7 +461,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -500,7 +504,7 @@
>> WRONG_PARAM_COUNT;
>> }
>> convert_to_long_ex(scale_param);
>> - scale = (int) (Z_LVAL_PP(scale_param)<0) ?
>> 0:Z_LVAL_PP(scale_param);
>> + scale = (int) (Z_LVAL_PP(scale_param) < 0) ? 0 :
>> Z_LVAL_PP(scale_param);
>> break;
>> default:
>> WRONG_PARAM_COUNT;
>> @@ -534,7 +538,7 @@
>> }
>>
>> convert_to_long_ex(new_scale);
>> - bc_precision = (Z_LVAL_PP(new_scale)<0) ? 0 : Z_LVAL_PP(new_scale);
>> + bc_precision = (Z_LVAL_PP(new_scale) < 0) ? 0 : Z_LVAL_PP(new_scale);
>>
>> RETURN_TRUE;
>> }
>>
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
--
<- For Sale! ->
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
