On Thu, 2003-06-05 at 15:08, Sterling Hughes wrote:
> On Thu, 2003-06-05 at 15:16, Moriyoshi Koizumi wrote:
> > The following part seems to cause memleaks. Is this really a right 
> > fix?
> > 
> > > + if (!PZVAL_IS_REF(node)) {
> > > +         zval_add_ref(&node);
> > > + }
> > > + 
> > 
> > /home/koizumi/src/php5/ext/dom/php_dom.c(814) :  Freeing 0x0831D19C (32 bytes),
> > script=/home/koizumi/src/php5/ext/dom/tests/dom001.php
> > /home/koizumi/src/php5/Zend/zend_hash.c(150) : Actual location (location was rel
> > ayed)
> > /home/koizumi/src/php5/ext/dom/php_dom.c(813) :  Freeing 0x0831D13C (44 bytes),
> > script=/home/koizumi/src/php5/ext/dom/tests/dom001.php
> > /home/koizumi/src/php5/ext/dom/php_dom.c(798) :  Freeing 0x08314B24 (24 bytes),
> > script=/home/koizumi/src/php5/ext/dom/tests/dom001.php
> > 
> 
> Yep.  But it doesn't crash. :)
> 

(just a note that this will probably be fixed differently, but for now,
its a fix).

-Sterling

> -sterling
> 
> > 
> > Moriyoshi
> -- 
> "People can have the Model T in any colour -- so long as it's black." 
>     - Henry Ford
-- 
"People can have the Model T in any colour -- so long as it's black." 
    - Henry Ford

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to