Sterling,

Extensions shouldn't really be using stuff like PZVAL_UNLOCK(). Can you explain what you are trying to accomplish?

Andi

At 12:33 AM 5/7/2003 +0000, Sterling Hughes wrote:
sterling Fri Jul 4 20:33:13 2003 EDT

  Modified files:
    /php-src/ext/simplexml      simplexml.c
  Log:
  not a temp var unless its a singular var


Index: php-src/ext/simplexml/simplexml.c
diff -u php-src/ext/simplexml/simplexml.c:1.49 php-src/ext/simplexml/simplexml.c:1.50
--- php-src/ext/simplexml/simplexml.c:1.49 Fri Jul 4 18:21:23 2003
+++ php-src/ext/simplexml/simplexml.c Fri Jul 4 20:33:13 2003
@@ -16,7 +16,7 @@
+----------------------------------------------------------------------+
*/


-/* $Id: simplexml.c,v 1.49 2003/07/04 22:21:23 sterling Exp $ */
+/* $Id: simplexml.c,v 1.50 2003/07/05 00:33:13 sterling Exp $ */

 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -179,11 +179,10 @@
                zval_dtor(return_value);
                FREE_ZVAL(return_value);
                return_value = value;
+       } else {
+               PZVAL_UNLOCK(return_value);
        }

-       /* create temporary variable */
-       PZVAL_UNLOCK(return_value);
-
        return return_value;
 }
 /* }}} */
@@ -1055,7 +1054,7 @@
 {
        php_info_print_table_start();
        php_info_print_table_header(2, "Simplexml support", "enabled");
-       php_info_print_table_row(2, "Revision", "$Revision: 1.49 $");
+       php_info_print_table_row(2, "Revision", "$Revision: 1.50 $");
        php_info_print_table_end();

}



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to