On July 21, 2003 06:30 pm, Sascha Schumann wrote: > On Mon, 21 Jul 2003, Ilia Alshanetsky wrote: > > iliaa Mon Jul 21 17:47:52 2003 EDT > > > > Added files: > > /php-src/ext/session/tests bug24592.phpt > > > > Modified files: > > /php-src/ext/session session.c > > Log: > > Fixed bug #24592 (Possible crash in session extnsion, with NULL values) > > This should be fixed in ZEND_SET_SYMBOL_WITH_LENGTH. Ugly > engine details must not leak into extension code.
In this case using ZEND_SET_SYMBOL_WITH_LENGTH is overkill. Majority of the code inside the macro is not used and the zend_hash_find() is needlesly duplicated if the macro is used. Change wise we are talking about 4 lines of code versus a 20 line macro most of which is unnecessary operations as far as this particular case in concerned. Ilia -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
