You should both run this past our Release Master before commiting to the PHP_4_3 branch. We're past the final RC remember.
Edin ----- Original Message ----- From: "Derick Rethans" <[EMAIL PROTECTED]> To: "Moriyoshi Koizumi" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Tuesday, August 19, 2003 10:40 AM Subject: Re: [PHP-CVS] cvs: php-src / NEWS /ext/mbstring mbstring.c/ext/mbstring/tests bug25140.phpt On Tue, 19 Aug 2003, Moriyoshi Koizumi wrote: > This patch doesn't seem that good. mb_convert_encoding() should return > false in case the conversion has failed. I'm going to commit an > additional fix to both branches in 6 hours or so. That wasn't in the docs, so I didn't know. Please fix that too then :) Derick -- "Interpreting what the GPL actually means is a job best left to those that read the future by examining animal entrails." -------------------------------------------------------------------- ----- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ -------------------------------------------------------------------- ----- -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php