tony2001                Wed Jan 28 02:15:56 2004 EDT

  Modified files:              
    /php-src/ext/oci8   oci8.c 
  Log:
  two fixes:
  -oci_lob_load shouldn't reset LOB's length to zero
  -Oracle feels bad, but reports no error, when trying to erase LOB with offset bigger 
than LOB
  
  
http://cvs.php.net/diff.php/php-src/ext/oci8/oci8.c?r1=1.243&r2=1.244&ty=u
Index: php-src/ext/oci8/oci8.c
diff -u php-src/ext/oci8/oci8.c:1.243 php-src/ext/oci8/oci8.c:1.244
--- php-src/ext/oci8/oci8.c:1.243       Mon Jan 26 10:42:24 2004
+++ php-src/ext/oci8/oci8.c     Wed Jan 28 02:15:55 2004
@@ -22,7 +22,7 @@
    +----------------------------------------------------------------------+
  */
 
-/* $Id: oci8.c,v 1.243 2004/01/26 15:42:24 tony2001 Exp $ */
+/* $Id: oci8.c,v 1.244 2004/01/28 07:15:55 tony2001 Exp $ */
 
 /* TODO list:
  *
@@ -785,7 +785,7 @@
 
        php_info_print_table_start();
        php_info_print_table_row(2, "OCI8 Support", "enabled");
-       php_info_print_table_row(2, "Revision", "$Revision: 1.243 $");
+       php_info_print_table_row(2, "Revision", "$Revision: 1.244 $");
 
        sprintf(buf, "%ld", num_persistent);
        php_info_print_table_row(2, "Active Persistent Links", buf);
@@ -2284,8 +2284,6 @@
                return -1;
        }
 
-       mydescr->lob_size = *loblen;
-       
        if (Z_TYPE_P(mydescr) == OCI_DTYPE_FILE) {
                CALL_OCI_RETURN(connection->error,
                        OCILobFileClose(
@@ -4475,6 +4473,10 @@
                if (erase_length < 1) {
                        RETURN_LONG(0);
                }
+
+               if (erase_offset > descr->lob_size) {
+                       php_error_docref(NULL TSRMLS_CC, E_WARNING, "oci_lob_erase(): 
offset is greater than LOB's length");
+               }
                
                CALL_OCI_RETURN(connection->error,
                        OCILobErase(

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to