[PHP-CVS] cvs: php-src(PHP_4_3) /ext/snmp snmp.c

[Ilia Alshanetsky]

iliaa           Tue Feb  3 09:44:17 2004 EDT

  Modified files:              (Branch: PHP_4_3)
    /php-src/ext/snmp   snmp.c 
  Log:
  MFH: Fixed possible overflow.
  
  
http://cvs.php.net/diff.php/php-src/ext/snmp/snmp.c?r1=1.70.2.13&r2=1.70.2.14&ty=u
Index: php-src/ext/snmp/snmp.c
diff -u php-src/ext/snmp/snmp.c:1.70.2.13 php-src/ext/snmp/snmp.c:1.70.2.14
--- php-src/ext/snmp/snmp.c:1.70.2.13   Thu Oct 16 22:21:37 2003
+++ php-src/ext/snmp/snmp.c     Tue Feb  3 09:44:17 2004
@@ -20,7 +20,7 @@
   +----------------------------------------------------------------------+
 */
 
-/* $Id: snmp.c,v 1.70.2.13 2003/10/17 02:21:37 iliaa Exp $ */
+/* $Id: snmp.c,v 1.70.2.14 2004/02/03 14:44:17 iliaa Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -573,7 +573,7 @@
        }
 
        snmp_sess_init(&session);
-       strcpy (hostname, Z_STRVAL_PP(a1));
+       strlcpy(hostname, Z_STRVAL_PP(a1), sizeof(hostname));
        if ((pptr = strchr (hostname, ':'))) {
                remote_port = strtol (pptr + 1, NULL, 0);
        }
@@ -889,7 +889,7 @@
 
        /* Reading the hostname and its optional non-default port number */
        convert_to_string_ex(a1);
-       strcpy(hostname, Z_STRVAL_PP(a1));
+       strlcpy(hostname, Z_STRVAL_PP(a1), sizeof(hostname));
        if ((pptr = strchr (hostname, ':'))) {
                remote_port = strtol (pptr + 1, NULL, 0);
        }

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php