At 09:35 PM 2/11/2004 +0100, Marcus Boerger wrote:
Hello Zeev,
Wednesday, February 11, 2004, 8:15:34 PM, you wrote:
> zeev Wed Feb 11 14:15:34 2004 EDT
> Modified files: > /php-src/ext/simplexml simplexml.c > Log: > Prevent SimpleXML from silently modifying types of variables that are > assigned to its objects.
> Implementation notes for overloaded object modules:
> - If you return a zval which is not otherwise referenced by the extension > or the engine's symbol table, its reference count should be 0. > - If you receive a value zval in write_property/write_dimension, you > may only modify it if its reference count is 1. Otherwise, you must > create a copy of that zval before making any changes. You should NOT > modify the reference count of the value passed to you.
Shouldn't that comment make it into a .h file near the place where the handler type is define? (aka documentation where it belong)
regards marcus
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
