Thanks Andi,
I'm planning a lot mor changes to the fbsql extension, but those will wait
til after the release.
The emalloc(17) is used to create a buffer for the digest function. It
always returns a 16 byte string. I guess I could use emalloc(16), but I'll
add a define like this:
#define DIGETS_BUFFER_SIZE 16
Would that help ?
- Frank
> Yep, we really shouldn't be adding new features.
> However, fbsql is pretty isolated and so is the patch so I think it's
OK.
> I really don't like the following piece of code though:
> digest = emalloc(17);
> Is it possible to use some #define or sizeof("foobar") so that it is
clear
> what 17 means?
>
> Thanks Jan.
>
> Andi
>
> At 00:26 27/02/2004 +0100, Jan Lehnardt wrote:
> >Hi,
> >On 26 Feb 2004, at 21:31, Frank M. Kromann wrote:
> >>fmk Thu Feb 26 15:31:15 2004 EDT
> >>
> >> Modified files:
> >> /php-src/ext/fbsql php_fbsql.c php_fbsql.h
> >> Log:
> >> Adding function to change user passwords
> >
> >bugfix-only-and-feature-freeze-please-check-with-andi-alert.
> >
> >Jan
> >--
> >
> >--
> >PHP CVS Mailing List (http://www.php.net/)
> >To unsubscribe, visit: http://www.php.net/unsub.php
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php