Hi Joe,

Certainly I received your patch, but I'm somewhat reluctant to apply
it because there's been an ongoing effort to clear the issue actually.

I'll then commit it to the original source tree too.

Apologies for not responding.

Moriyoshi

On 2005/01/10, at 21:50, Joe Orton wrote:

On Mon, Jan 10, 2005 at 12:52:15PM +0100, Derick Rethans wrote:
jorton          Mon Jan 10 06:26:56 2005 EDT

  Modified files:
    /php-src/ext/mbstring/libmbfl/filters       mbfilter_htmlent.c
  Log:
  Don't scribble over the stack; icc compiler warning fix
  from [EMAIL PROTECTED] via Red Hat bugzilla #143795.

You can't change this code, it's LGPL so it should be fixed in the original library too otherwise we get into license problems :(

I mailed the diff to Moriyoshi too, or is it prefered that there are *no* local changes made to the libmbfl in the PHP tree? Should I back it out? (I can't see what license problems there could be)

joe


-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to