With your change, the leak will occur when removing specified attributes which are not referenced by a PHP object, not defaulted ones.
Yup, positive


Rob

Ilia Alshanetsky wrote:

Rob Richards wrote:

Can you revert this? Working on a fix, but need to apply it in a few more places, but taking a bit as I had a computer meltdown.
First time I ever saw an error message saying things are screwed, please reinstall operating system :)


According to valgrind there is no leak through the removal of that free command. Are you sure it's safe to treat the value as both a node and an attribute at the same time? If that's fine, I'll go head with the revert.

Ilia



-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to