Keep in mind that we only want to use POSIX-compatible ICU functions
for ext/ctype. The full range of character properties will be
available via ext/unicode.
-Andrei
On Aug 17, 2005, at 1:42 PM, Ilia Alshanetsky wrote:
Yeah, I'll put it on my todo.
Ilia
Dmitry Stogov wrote:
You probably right.
Can you do it by you self?
Dmitry.
-----Original Message-----
From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED]
Sent: Wednesday, August 17, 2005 6:25 PM
To: Dmitry Stogov
Cc: php-cvs@lists.php.net
Subject: Re: [PHP-CVS] cvs: php-src /ext/ctype ctype.c
Dmitry,
Would it not be better to emulate ctype functionality via
equivalent ICU functions/macros when the given value is Unicode?
Ilia
Dmitry Stogov wrote:
dmitry Wed Aug 17 10:16:06 2005 EDT
Modified files:
/php-src/ext/ctype ctype.c
Log:
Unicode support
http://cvs.php.net/diff.php/php-src/ext/ctype/ctype.c?
r1=1.34&r2=1.35&
ty=u
Index: php-src/ext/ctype/ctype.c
diff -u php-src/ext/ctype/ctype.c:1.34
php-src/ext/ctype/ctype.c:1.35
--- php-src/ext/ctype/ctype.c:1.34 Wed Aug 3 10:06:43 2005
+++ php-src/ext/ctype/ctype.c Wed Aug 17 10:16:05 2005
@@ -105,6 +105,8 @@
SEPARATE_ZVAL(&c); \
convert_to_string(c); \
case IS_STRING: \
+ case IS_BINARY: \
+string:\
{ \
char *p = Z_STRVAL_P(c), *e =
Z_STRVAL_P(c) + Z_STRLEN_P(c); \
if (e == p) { \
@@ -115,6 +117,9 @@
} \
RETURN_TRUE; \
} \
+ case IS_UNICODE: \
+ convert_to_string(c); \
+ goto string; \
default: \
break; \
} \
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
