Yes. Seems like traversable is broken in some cases.
Need Marcus to look at it.
--Wez.
Dmitry Stogov wrote:
Seems this patch breaks test pdo_014.phpt.
Dmitry.
-----Original Message-----
From: Wez Furlong [mailto:[EMAIL PROTECTED]
Sent: Sunday, September 11, 2005 6:27 PM
To: [email protected]
Subject: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/pdo pdo_stmt.c
wez Sun Sep 11 10:27:11 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/pdo pdo_stmt.c
Log:
remove traversable interface; apparently it's not enough,
and this stuff is too
magical to figure out wtf should be added.
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_stmt.c?r1=1.11
8.2.4&r2=1.118.2.5&ty=u
Index: php-src/ext/pdo/pdo_stmt.c
diff -u php-src/ext/pdo/pdo_stmt.c:1.118.2.4
php-src/ext/pdo/pdo_stmt.c:1.118.2.5
--- php-src/ext/pdo/pdo_stmt.c:1.118.2.4 Sat Sep 10 15:32:15 2005
+++ php-src/ext/pdo/pdo_stmt.c Sun Sep 11 10:27:10 2005
@@ -18,7 +18,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pdo_stmt.c,v 1.118.2.4 2005/09/10 19:32:15 wez Exp $ */
+/* $Id: pdo_stmt.c,v 1.118.2.5 2005/09/11 14:27:10 wez Exp $ */
/* The PDO Statement Handle Class */
@@ -1990,7 +1990,9 @@
pdo_dbstmt_ce = zend_register_internal_class(&ce TSRMLS_CC);
pdo_dbstmt_ce->get_iterator = pdo_stmt_iter_get;
pdo_dbstmt_ce->create_object = pdo_dbstmt_new;
+#if no_crazy_hidden_deps_on_other_interfaces
zend_class_implements(pdo_dbstmt_ce TSRMLS_CC, 1,
zend_ce_traversable);
+#endif
zend_declare_property_null(pdo_dbstmt_ce, "queryString",
sizeof("queryString")-1, ZEND_ACC_PUBLIC TSRMLS_CC);
memcpy(&pdo_dbstmt_object_handlers, &std_object_handlers,
sizeof(zend_object_handlers));
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
