Hi Jani, You are right. ZVAL_U_STRING(ZEND_U_CONVERTER(UG(runtime_encoding_conv))... is equivalent to ZVAL_RT_STRING. But simplexml should use not "runtime encoding", but "XML document encoding" instead.
I hope maintainers will change this. Thanks. Dmitry. > -----Original Message----- > From: Jani Taskinen [mailto:[EMAIL PROTECTED] > Sent: Wednesday, December 07, 2005 8:23 PM > To: Dmitry Stogov > Cc: [email protected] > Subject: Re: [PHP-CVS] cvs: php-src /ext/simplexml > simplexml.c /ext/simplexml/tests000.phpt 001.phpt 002.phpt > 003.phpt 004.phpt 007.phpt 010.phpt 022.phpt023.phpt 024.phpt > /ext/spl/tests sxe_001.phpt > > > > All these macros around and you still duplicate the stuff? > > Instead of doing: > > ZVAL_U_STRING(ZEND_U_CONVERTER(UG(runtime_encoding_conv))... > > Why not use the ZVAL_RT_STRING macro? (What is RT > supposed to be anyway?) > > --Jani > > > On Wed, 7 Dec 2005, Dmitry Stogov wrote: > > > dmitry Wed Dec 7 11:52:13 2005 EDT > > > > Modified files: > > /php-src/ext/simplexml simplexml.c > > /php-src/ext/simplexml/tests 000.phpt 001.phpt > 002.phpt 003.phpt > > 004.phpt 007.phpt > 010.phpt 022.phpt > > 023.phpt 024.phpt > > /php-src/ext/spl/tests sxe_001.phpt > > Log: > > Unicode support > > > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
