tony2001 Sun Dec 18 22:52:25 2005 EDT Modified files: (Branch: PHP_5_1) /php-src/ext/spl spl_iterators.c Log: fix leak in SPL iterators http://cvs.php.net/viewcvs.cgi/php-src/ext/spl/spl_iterators.c?r1=1.73.2.8&r2=1.73.2.9&diff_format=u Index: php-src/ext/spl/spl_iterators.c diff -u php-src/ext/spl/spl_iterators.c:1.73.2.8 php-src/ext/spl/spl_iterators.c:1.73.2.9 --- php-src/ext/spl/spl_iterators.c:1.73.2.8 Tue Dec 6 02:00:14 2005 +++ php-src/ext/spl/spl_iterators.c Sun Dec 18 22:52:24 2005 @@ -16,7 +16,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: spl_iterators.c,v 1.73.2.8 2005/12/06 02:00:14 sniper Exp $ */ +/* $Id: spl_iterators.c,v 1.73.2.9 2005/12/18 22:52:24 tony2001 Exp $ */ #ifdef HAVE_CONFIG_H # include "config.h" @@ -814,7 +814,7 @@ static INLINE spl_dual_it_object* spl_dual_it_construct(INTERNAL_FUNCTION_PARAMETERS, zend_class_entry *ce_inner, dual_it_type dit_type) { - zval *zobject; + zval *zobject, *retval = NULL; spl_dual_it_object *intern; zend_class_entry *ce; @@ -882,7 +882,6 @@ ce = *pce_cast; } if (instanceof_function(ce, zend_ce_aggregate TSRMLS_CC)) { - zval *retval; zobject = zend_call_method_with_0_params(&zobject, ce, &ce->iterator_funcs.zf_new_iterator, "getiterator", &retval); ce = Z_OBJCE_P(zobject); } @@ -911,6 +910,10 @@ intern->inner.object = zend_object_store_get_object(zobject TSRMLS_CC); intern->inner.iterator = intern->inner.ce->get_iterator(intern->inner.ce, zobject TSRMLS_CC); + if (retval) { + zval_ptr_dtor(&retval); + } + php_set_error_handling(EH_NORMAL, NULL TSRMLS_CC); return intern; }
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php