UNICODE_* or whatever....
We agreed a long time ago that we will namespace all new constants &
functions going forward. I don't see why this should be any different
unless you are thinking of creating FROM_* and TO_* (which I
obviously think is a bad idea).
Andi
At 09:30 AM 3/27/2006, Andrei Zmievski wrote:
Namespace them to what? It's a short and understandable name that
will be used a lot..
-Andrei
On Mar 26, 2006, at 9:51 PM, Andi Gutmans wrote:
We should namespaces these and all other unicode constants...
+ REGISTER_MAIN_LONG_CONSTANT("FROM_UNICODE",
ZEND_FROM_UNICODE, CONST_PERSISTENT | CONST_CS);
+ REGISTER_MAIN_LONG_CONSTANT("TO_UNICODE", ZEND_TO_UNICODE,
CONST_PERSISTENT | CONST_CS);
At 05:48 PM 3/25/2006, Andrei Zmievski wrote:
andrei Sun Mar 26 01:48:33 2006 UTC
Modified files:
/ZendEngine2 zend.c zend_constants.c zend_globals.h
zend_unicode.c
zend_unicode.h
/php-src/ext/unicode unicode.c
/php-src/main main.c
/php-src/main/streams filter.c streams.c
Log:
* Remove unicode.from_error_mode and unicode.from_subst_char from INI
settings.
* Add unicode_set_error_mode() and unicode_set_subst_char() functions to
manipulate these global settings.
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
