On Tue, 27 Jun 2006, Nuno Lopes wrote:
nlopess Tue Jun 27 19:48:02 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/date php_date.c
/php-src/ext/date/lib dow.c parse_tz.c timezonedb.h
Log:
add a couple of static and const keywords, to let the compiler optimize
better
will MFB in a hour, or so
Ho... please discuss those things first before just committing. You're
modifying all kinds of generated files here as well. So, please come up
with some proposal first before committing (and I'd say revert for now)
regards,
Derick
Sure, I've reverted it.
I didn't thought this would be so confusing, thats why I didn't ask anything
in the mailing list.
Anyway, the patch is here: http://mega.ist.utl.pt/~ncpl/php_date_consts.txt
It simply add a couple of static and const keywords to allow better
optimizations by the compilers (this is specially important when building
the shared library).
Please take a look at the patch and tell me what you think (there were no
test regressions, btw).
Thanks,
Nuno
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
