Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/dom element.c /ext/dom/tests bug38949.phpt nsdoc.xml

[Rob Richards]

Antony Dovgal wrote:
On 27.09.2006 14:31, Rob Richards wrote:
     attr = dom_get_dom1_attribute(nodep, (xmlChar *)name);
-    if (attr != NULL && attr->type != XML_ATTRIBUTE_DECL) {
+    if (attr != NULL) {
+        switch (attr->type) {
+            case XML_ATTRIBUTE_NODE:
         node_list_unlink(attr->children TSRMLS_CC);
+                break;
+            case XML_NAMESPACE_DECL:
+                RETURN_FALSE;
+        }
+
+    }

No default action ?

Nope. I wont get a chance to change it till tomorrow, so can you either 
add a default doing nothing or if/else that?

Rob

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php