On 8-Nov-06, at 12:13 PM, Dmitry Stogov wrote:
Sure!
No, you're right, it looks like I went a bit too far with find &
replace when fixing the test.
May be you forgot commit some peace of patch?
The last element still shows up be reference because the reference
flag from it is never cleared, which looks to be the correct behavior
to me.
I see references at last elements of some arrays in actual output.
Thanks. Dmitry.
-----Original Message-----
From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] On Behalf Of
Ilia Alshanetsky
Sent: Wednesday, November 08, 2006 6:59 PM
To: Dmitry Stogov
Cc: php-cvs@lists.php.net
Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2)
/ext/standard/tests/array array_diff_key.phpt
array_intersect_key.phpt
They pass on my system, are you sure it is not related to
another patch?
On 8-Nov-06, at 3:17 AM, Dmitry Stogov wrote:
Seems this fix is not completely right.
The tests still failed.
Thanks. Dmitry.
-----Original Message-----
From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED]
Sent: Tuesday, November 07, 2006 11:25 PM
To: php-cvs@lists.php.net
Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard/tests/array
array_diff_key.phpt array_intersect_key.phpt
iliaa Tue Nov 7 20:24:38 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/standard/tests/array array_diff_key.phpt
array_intersect_key.phpt
Log:
Fixed tests
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/array
/array_diff_key.phpt?r1=1.1&r2=1.1.4.1&diff_format=u
Index: php-src/ext/standard/tests/array/array_diff_key.phpt
diff -u php-src/ext/standard/tests/array/array_diff_key.phpt:1.1
php-src/ext/standard/tests/array/array_diff_key.phpt:1.1.4.1
--- php-src/ext/standard/tests/array/array_diff_key.phpt:1.1
Wed Jul 21 21:17:56 2004
+++ php-src/ext/standard/tests/array/array_diff_key.phpt
Tue Nov 7 20:24:38 2006
@@ -66,13 +66,13 @@
------ Test 1 --------
array(4) {
[1]=>
- &int(2)
+ int(2)
[6]=>
- &int(12)
+ int(12)
[15]=>
- &int(30)
+ int(30)
[1200]=>
- &int(2400)
+ int(2400)
}
array(4) {
[1]=>
@@ -114,7 +114,7 @@
[1200]=>
int(2400)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(6) {
[1]=>
@@ -128,7 +128,7 @@
[1200]=>
int(2400)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
------ Test 4 --------
array(3) {
@@ -188,11 +188,11 @@
------ Test 7 --------
array(3) {
[7]=>
- &int(14)
+ int(14)
[11]=>
- &int(22)
+ int(22)
[1100]=>
- &int(2200)
+ int(2200)
}
array(3) {
[7]=>
@@ -215,7 +215,7 @@
[1100]=>
int(2200)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(6) {
[0]=>
@@ -229,7 +229,7 @@
[1100]=>
int(2200)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
------ Test 9 --------
array(3) {
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/array
/array_intersect_key.phpt?r1=1.1&r2=1.1.4.1&diff_format=u
Index: php-src/ext/standard/tests/array/array_intersect_key.phpt
diff -u
php-src/ext/standard/tests/array/array_intersect_key.phpt:1.1
php-src/ext/standard/tests/array/array_intersect_key.phpt:1.1.4.1
---
php-src/ext/standard/tests/array/array_intersect_key.phpt:1.1
Wed Jul 21 21:17:56 2004
+++ php-src/ext/standard/tests/array/array_intersect_key.phpt
Tue Nov 7 20:24:38 2006
@@ -62,11 +62,11 @@
--EXPECTF--
array(3) {
[2]=>
- &int(4)
+ int(4)
[-20]=>
- &int(-40)
+ int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(3) {
[2]=>
@@ -74,7 +74,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(4) {
[6]=>
@@ -84,7 +84,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(4) {
[6]=>
@@ -94,7 +94,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(1) {
[-20]=>
@@ -110,7 +110,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(3) {
[2]=>
@@ -118,7 +118,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(1) {
[-20]=>
@@ -138,13 +138,13 @@
}
array(4) {
[0]=>
- &int(0)
+ int(0)
[2]=>
- &int(4)
+ int(4)
[-20]=>
- &int(-40)
+ int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(4) {
[0]=>
@@ -154,7 +154,7 @@
[-20]=>
int(-40)
[-2500]=>
- &int(-5000)
+ int(-5000)
}
array(1) {
[-20]=>
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Ilia Alshanetsky
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Ilia Alshanetsky
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
