That's some scary code there, Sara. What about endianness and portability?

-Andrei

On Dec 4, 2006, at 8:52 PM, Sara Golemon wrote:

+       if (str_type == IS_UNICODE) {
+               UChar udelim = ',', uenc = '"', uesc = '\\';
+
+ /* Non-passed params would need to be upconverted, but we can cheat with some local declarations */
+               if (delim_type == IS_STRING) {
+                       delim = (char*)&udelim;
+                       delim_len = 1;
+               }
+               if (enc_type == IS_STRING) {
+                       enc = (char*)&uenc;
+                       enc_len = 1;
+               }
+               if (esc_type == IS_STRING) {
+                       esc = (char*)&uesc;
+                       esc_len = 1;
+               }

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to