helly           Tue May 29 08:44:06 2007 UTC

  Modified files:              (Branch: PHP_5_2)
    /php-src    NEWS 
    /php-src/ext/reflection     php_reflection.c 
  Log:
  - Bug #41525 ReflectionParameter::getPosition() not available
  # This was supposed to be dropped in 5.1.4, I wonder why thisis not in
  # because the functionality is documented.
  # [ DOC ] Make sure the function documentation is correct for:
  # ReflectionParameter::getPosition
  # ReflectionParameter::getDeclaringFunction
  # ReflectionFunction::getExtension
  # ReflectionFunction::getExtensionName
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.743&r2=1.2027.2.547.2.744&diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.743 php-src/NEWS:1.2027.2.547.2.744
--- php-src/NEWS:1.2027.2.547.2.743     Mon May 28 10:36:09 2007
+++ php-src/NEWS        Tue May 29 08:44:05 2007
@@ -1,6 +1,7 @@
 PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? Jun 2007, PHP 5.2.3
+- Fixed bug #41525 (ReflectionParameter::getPosition() not available). (Marcus)
 - Fixed bug #41511 (Compile failure under IRIX 6.5.30 building md5.c). (Jani)
 - Fixed bug #41504 (json_decode() incorrectly decodes JSON arrays with empty
   string keys). (Ilia)
http://cvs.php.net/viewvc.cgi/php-src/ext/reflection/php_reflection.c?r1=1.164.2.33.2.38&r2=1.164.2.33.2.39&diff_format=u
Index: php-src/ext/reflection/php_reflection.c
diff -u php-src/ext/reflection/php_reflection.c:1.164.2.33.2.38 
php-src/ext/reflection/php_reflection.c:1.164.2.33.2.39
--- php-src/ext/reflection/php_reflection.c:1.164.2.33.2.38     Mon May 28 
10:46:21 2007
+++ php-src/ext/reflection/php_reflection.c     Tue May 29 08:44:05 2007
@@ -20,7 +20,7 @@
    +----------------------------------------------------------------------+
 */
 
-/* $Id: php_reflection.c,v 1.164.2.33.2.38 2007/05/28 10:46:21 bjori Exp $ */
+/* $Id: php_reflection.c,v 1.164.2.33.2.39 2007/05/29 08:44:05 helly Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -707,11 +707,10 @@
        if (fptr->common.fn_flags & ZEND_ACC_DEPRECATED) {
                string_printf(str, ", deprecated");
        }
-#if MBO_0
        if (fptr->type == ZEND_INTERNAL_FUNCTION && 
((zend_internal_function*)fptr)->module) {
                string_printf(str, ":%s", 
((zend_internal_function*)fptr)->module->name);
        }
-#endif
+
        if (scope && fptr->common.scope) {
                if (fptr->common.scope != scope) {
                        string_printf(str, ", inherits %s", 
fptr->common.scope->name);
@@ -1741,7 +1740,6 @@
 }
 /* }}} */
 
-#if MBO_0
 /* {{{ proto public ReflectionExtension|NULL ReflectionFunction::getExtension()
    Returns NULL or the extension the function belongs to */
 ZEND_METHOD(reflection_function, getExtension)
@@ -1765,9 +1763,7 @@
        }
 }
 /* }}} */
-#endif
 
-#if MBO_0
 /* {{{ proto public string|false ReflectionFunction::getExtensionName()
    Returns false or the name of the extension the function belongs to */
 ZEND_METHOD(reflection_function, getExtensionName)
@@ -1791,7 +1787,6 @@
        }
 }
 /* }}} */
-#endif
 
 /* {{{ proto public static mixed ReflectionParameter::export(mixed function, 
mixed parameter [, bool return]) throws ReflectionException
    Exports a reflection object. Returns the output if TRUE is specified for 
return, printing it otherwise. */
@@ -1956,7 +1951,6 @@
 }
 /* }}} */
 
-#if MBO_0
 /* {{{ proto public ReflectionFunction 
ReflectionParameter::getDeclaringFunction()
    Returns the ReflectionFunction for the function of this parameter */
 ZEND_METHOD(reflection_parameter, getDeclaringFunction)
@@ -1974,7 +1968,6 @@
        }
 }
 /* }}} */
-#endif
 
 /* {{{ proto public ReflectionClass|NULL 
ReflectionParameter::getDeclaringClass()
    Returns in which class this parameter is defined (not the typehint of the 
parameter) */
@@ -2089,7 +2082,6 @@
 }
 /* }}} */
 
-#if MBO_0
 /* {{{ proto public bool ReflectionParameter::getPosition()
    Returns whether this parameter is an optional parameter */
 ZEND_METHOD(reflection_parameter, getPosition)
@@ -2103,7 +2095,6 @@
        RETVAL_LONG(param->offset);
 }
 /* }}} */
-#endif
 
 /* {{{ proto public bool ReflectionParameter::isOptional()
    Returns whether this parameter is an optional parameter */
@@ -4458,10 +4449,8 @@
        ZEND_ME(reflection_function, getParameters, NULL, 0)
        ZEND_ME(reflection_function, getNumberOfParameters, NULL, 0)
        ZEND_ME(reflection_function, getNumberOfRequiredParameters, NULL, 0)
-#if MBO_0
        ZEND_ME(reflection_function, getExtension, NULL, 0)
        ZEND_ME(reflection_function, getExtensionName, NULL, 0)
-#endif
        ZEND_ME(reflection_function, isDeprecated, NULL, 0)
        {NULL, NULL, NULL}
 };
@@ -4735,16 +4724,12 @@
        ZEND_ME(reflection_parameter, __toString, NULL, 0)
        ZEND_ME(reflection_parameter, getName, NULL, 0)
        ZEND_ME(reflection_parameter, isPassedByReference, NULL, 0)
-#if MBO_0
        ZEND_ME(reflection_parameter, getDeclaringFunction, NULL, 0)
-#endif
        ZEND_ME(reflection_parameter, getDeclaringClass, NULL, 0)
        ZEND_ME(reflection_parameter, getClass, NULL, 0)
        ZEND_ME(reflection_parameter, isArray, NULL, 0)
        ZEND_ME(reflection_parameter, allowsNull, NULL, 0)
-#if MBO_0
        ZEND_ME(reflection_parameter, getPosition, NULL, 0)
-#endif
        ZEND_ME(reflection_parameter, isOptional, NULL, 0)
        ZEND_ME(reflection_parameter, isDefaultValueAvailable, NULL, 0)
        ZEND_ME(reflection_parameter, getDefaultValue, NULL, 0)
@@ -4893,7 +4878,7 @@
        php_info_print_table_start();
        php_info_print_table_header(2, "Reflection", "enabled");
 
-       php_info_print_table_row(2, "Version", "$Id: php_reflection.c,v 
1.164.2.33.2.38 2007/05/28 10:46:21 bjori Exp $");
+       php_info_print_table_row(2, "Version", "$Id: php_reflection.c,v 
1.164.2.33.2.39 2007/05/29 08:44:05 helly Exp $");
 
        php_info_print_table_end();
 } /* }}} */


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to