Hello Jani, please don't excclude them. Instead we could check which extensions are loaded in the executed php and exclude them fro being loaded as shared again. Since we test the executed version to get its version etc that should be easy enough.
best regards marcus Thursday, June 7, 2007, 12:04:38 PM, you wrote: > I was afraid that would happen. > But can't those warnings be suppressed either by excluding > E_CORE_WARNING in error_reporting directive or by setting > display_startup_errors to off..? > Another issue that might be a problem is that you have some extension > in your php.ini which you're not compiling the time you run 'make test'. > Can't remember if that causes a fatal error or what..(if extension does > not exist > --Jani > On Thu, 2007-06-07 at 11:27 +0400, Dmitry Stogov wrote: >> Hi Jani, >> >> After this patch all my tests failed, because PHP tries to load extensions >> twice. >> First from php.ini and then from command line (-d extension=...). >> >> I like your idea, as it's going to allow testing of ALL compileed extensions >> before installation, but it doesn't work yet. >> >> Thanks. Dmitry. >> >> > -----Original Message----- >> > From: Jani Taskinen [mailto:[EMAIL PROTECTED] >> > Sent: Wednesday, June 06, 2007 10:28 PM >> > To: php-cvs@lists.php.net >> > Subject: [PHP-CVS] cvs: php-src(PHP_5_2) / Makefile.global >> > >> > >> > sniper Wed Jun 6 18:28:14 2007 UTC >> > >> > Modified files: (Branch: PHP_5_2) >> > /php-src Makefile.global >> > Log: >> > MFH:- Fix passing of shared extensions to run-tests.php >> > >> > http://cvs.php.net/viewvc.cgi/php-src/Makefile.global?r1=1.57. >> > 2.5.2.2&r2=1.57.2.5.2.3&diff_format=u >> > Index: php-src/Makefile.global >> > diff -u php-src/Makefile.global:1.57.2.5.2.2 >> > php-src/Makefile.global:1.57.2.5.2.3 >> > --- php-src/Makefile.global:1.57.2.5.2.2 Wed Apr 11 16:03:06 2007 >> > +++ php-src/Makefile.global Wed Jun 6 18:28:13 2007 >> > @@ -69,22 +69,26 @@ >> > >> > install-su: install-pear >> > >> > +PHP_TEST_SHARED_EXTENSIONS=`(for i in $(PHP_MODULES); do . >> > $$i ; echo >> > +-n "-d extension=$$dlname "; done)` PHP_TEST_SETTINGS=-d >> > +'open_basedir=' -d 'safe_mode=0' -d 'output_buffering=0' -d >> > +'memory_limit=-1' >> > + >> > test: all >> > [EMAIL PROTECTED] test ! -z "$(PHP_EXECUTABLE)" && test -x >> > "$(PHP_EXECUTABLE)"; then \ >> > TEST_PHP_EXECUTABLE=$(PHP_EXECUTABLE) \ >> > TEST_PHP_SRCDIR=$(top_srcdir) \ >> > CC="$(CC)" \ >> > - $(PHP_EXECUTABLE) -d 'open_basedir=' -d >> > 'safe_mode=0' -d 'output_buffering=0' -d 'memory_limit=-1' >> > $(top_srcdir)/run-tests.php -d 'extension_dir=modules/' -d `( >> > . $(PHP_MODULES) ; echo extension=$$dlname)` tests/; \ >> > + $(PHP_EXECUTABLE) $(PHP_TEST_SETTINGS) >> > $(top_srcdir)/run-tests.php >> > +-d extension_dir=modules/ $(PHP_TEST_SHARED_EXTENSIONS) tests/; \ >> > elif test ! -z "$(SAPI_CLI_PATH)" && test -x >> > "$(SAPI_CLI_PATH)"; then \ >> > TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \ >> > TEST_PHP_SRCDIR=$(top_srcdir) \ >> > CC="$(CC)" \ >> > - $(top_builddir)/$(SAPI_CLI_PATH) -d >> > 'open_basedir=' -d 'safe_mode=0' -d 'output_buffering=0' -d >> > 'memory_limit=-1' $(top_srcdir)/run-tests.php $(TESTS); \ >> > + $(top_builddir)/$(SAPI_CLI_PATH) >> > $(PHP_TEST_SETTINGS) >> > +$(top_srcdir)/run-tests.php -d >> > extension_dir=$(top_builddir)/modules/ >> > $(PHP_TEST_SHARED_EXTENSIONS) $(TESTS); \ >> > else \ >> > echo "ERROR: Cannot run tests without CLI sapi."; \ >> > fi >> > >> > clean: >> > + find . -name \*.gcno -o -name \*.gcda | xargs rm -f >> > find . -name \*.lo -o -name \*.o | xargs rm -f >> > find . -name \*.la -o -name \*.a | xargs rm -f >> > find . -name \*.so | xargs rm -f >> > >> > -- >> > PHP CVS Mailing List (http://www.php.net/) >> > To unsubscribe, visit: http://www.php.net/unsub.php >> > >> Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
