The test is universal, on 64 bit machines you will get int because PHP int is actually a long. The -LONG_MAX is a good point though.

On 13-Jun-07, at 1:11 PM, Stanislav Malyshev wrote:

+       double d = zend_strtod(buf->c, NULL);
+       if (d > LONG_MAX) {


Shouldn't it be d > LONG_MAX || d < -LONG_MAX?

-    int(4000000000000)
+    %s(4000000000000)

If it's 32-bit it's always float, no chance to get int (4000000000000) from PHP, so why %s?
--
Stanislav Malyshev, Zend Products Engineer
[EMAIL PROTECTED]  http://www.zend.com/


Ilia Alshanetsky

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to