Re: [PHP-CVS] cvs: php-src(PHP_5_3) / run-tests.php

[Nuno Lopes]

nlopess         Fri Feb  8 16:46:23 2008 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src    run-tests.php
  Log:
  fix ===DONE=== with windows EOLs

http://cvs.php.net/viewvc.cgi/php-src/run-tests.php?r1=1.226.2.37.2.35.2.14&r2=1.226.2.37.2.35.2.15&diff_format=u
Index: php-src/run-tests.php
diff -u php-src/run-tests.php:1.226.2.37.2.35.2.14
php-src/run-tests.php:1.226.2.37.2.35.2.15
--- php-src/run-tests.php:1.226.2.37.2.35.2.14  Tue Jan 15 13:03:54 2008
+++ php-src/run-tests.php       Fri Feb  8 16:46:23 2008
@@ -1077,7 +1077,7 @@
                }

                // End of actual test?
-               if ($secfile && preg_match('/^===DONE===$/', $line)) {
+               if ($secfile && preg_match('/^===DONE===\s*$/', $line)) {
                        $secdone = true;
                }
        }


should that not read /^===DONE===\r?$/  ?

to be strict, yes, but I don't think we need to be soo strict. Imagine you 
left a tab after ===DONE===, I think we can allow that as well.
Nuno 

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php