Hello Josie,

Tuesday, February 19, 2008, 6:03:11 PM, you wrote:

> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/array/each_error.phpt?r1=1.1&r2=1.2&diff_format=u
> Index: php-src/ext/standard/tests/array/each_error.phpt
> diff -u /dev/null php-src/ext/standard/tests/array/each_error.phpt:1.2
> --- /dev/null   Tue Feb 19 17:03:11 2008
> +++ php-src/ext/standard/tests/array/each_error.phpt    Tue Feb 19 17:03:11 
> 2008
[...]
> +
> +echo "Done";
+?>>
> +
> +--EXPECTF--
[..]
> +Done
> \ No newline at end of file


Leads me to the following comments:
- Always have an empty line at the end to please CVS, run-tests.php will
take care of this.

- use a line '===DONE===' after the '?>' line. Because that has additional
meaning to run/tests. An echo statement at the end doesn't. Also why done at
the end when it can be php like simply outside the script tags?

- No additional emoty line between '?>' and the first expect block. The
run-tests script might stumble over this when comparing the result with the
expectated result.

Best regards,
 Marcus

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to