andrey Thu Mar 20 15:29:14 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/mysqli/tests mysqli_stmt_bind_param_check_param_no_change.phpt
Modified files: /php-src/ext/mysqlnd mysqlnd_ps_codec.c Log: Small fix and a test case to prove it's right http://cvs.php.net/viewvc.cgi/php-src/ext/mysqlnd/mysqlnd_ps_codec.c?r1=1.3.2.6&r2=1.3.2.7&diff_format=u Index: php-src/ext/mysqlnd/mysqlnd_ps_codec.c diff -u php-src/ext/mysqlnd/mysqlnd_ps_codec.c:1.3.2.6 php-src/ext/mysqlnd/mysqlnd_ps_codec.c:1.3.2.7 --- php-src/ext/mysqlnd/mysqlnd_ps_codec.c:1.3.2.6 Thu Mar 20 14:03:30 2008 +++ php-src/ext/mysqlnd/mysqlnd_ps_codec.c Thu Mar 20 15:29:14 2008 @@ -18,7 +18,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: mysqlnd_ps_codec.c,v 1.3.2.6 2008/03/20 14:03:30 andrey Exp $ */ +/* $Id: mysqlnd_ps_codec.c,v 1.3.2.7 2008/03/20 15:29:14 andrey Exp $ */ #include "php.h" #include "mysqlnd.h" #include "mysqlnd_wireprotocol.h" @@ -828,14 +828,7 @@ *p = php_mysqlnd_net_store_length(*p, 0); } break; - case MYSQL_TYPE_VAR_STRING: - /* - If the user uses refs, it could be that the type has - has changed and we need to convert, again. Which is noop, - if the type hasn't changed. - */ - convert_to_string_ex(&stmt->param_bind[i].zv); - { + case MYSQL_TYPE_VAR_STRING:{ unsigned int len = Z_STRLEN_P(data); /* to is after p. The latter hasn't been moved */ *p = php_mysqlnd_net_store_length(*p, len); http://cvs.php.net/viewvc.cgi/php-src/ext/mysqli/tests/mysqli_stmt_bind_param_check_param_no_change.phpt?view=markup&rev=1.1 Index: php-src/ext/mysqli/tests/mysqli_stmt_bind_param_check_param_no_change.phpt +++ php-src/ext/mysqli/tests/mysqli_stmt_bind_param_check_param_no_change.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php