helly Tue Mar 25 21:58:03 2008 UTC Modified files: /php-src/sapi/cli php_cli.c Log: - Use sizeof rather than strlen and cleanup http://cvs.php.net/viewvc.cgi/php-src/sapi/cli/php_cli.c?r1=1.187&r2=1.188&diff_format=u Index: php-src/sapi/cli/php_cli.c diff -u php-src/sapi/cli/php_cli.c:1.187 php-src/sapi/cli/php_cli.c:1.188 --- php-src/sapi/cli/php_cli.c:1.187 Wed Mar 19 16:37:49 2008 +++ php-src/sapi/cli/php_cli.c Tue Mar 25 21:58:03 2008 @@ -20,7 +20,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: php_cli.c,v 1.187 2008/03/19 16:37:49 rasmus Exp $ */ +/* $Id: php_cli.c,v 1.188 2008/03/25 21:58:03 helly Exp $ */ #include "php.h" #include "php_globals.h" @@ -115,13 +115,13 @@ PHP_MODE_SHOW_INI_CONFIG }; -#define HARDCODED_INI \ - "html_errors=0\n" \ - "register_argc_argv=1\n" \ - "implicit_flush=1\n" \ - "output_buffering=0\n" \ - "max_execution_time=0\n" \ - "max_input_time=-1\n" +const char HARDCODED_INI[] = + "html_errors=0\n" + "register_argc_argv=1\n" + "implicit_flush=1\n" + "output_buffering=0\n" + "max_execution_time=0\n" + "max_input_time=-1\n\0"; static char *php_optarg = NULL; static int php_optind = 1; @@ -671,10 +671,9 @@ setmode(_fileno(stderr), O_BINARY); /* make the stdio mode be binary */ #endif - ini_entries_len = strlen(HARDCODED_INI); - cli_sapi_module.ini_entries = malloc(ini_entries_len+2); - memcpy(cli_sapi_module.ini_entries, HARDCODED_INI, ini_entries_len+1); - cli_sapi_module.ini_entries[ini_entries_len+1] = 0; + ini_entries_len = sizeof(HARDCODED_INI)-2; + cli_sapi_module.ini_entries = malloc(sizeof(HARDCODED_INI)); + memcpy(cli_sapi_module.ini_entries, HARDCODED_INI, sizeof(HARDCODED_INI)); while ((c = php_getopt(argc, argv, OPTIONS, &php_optarg, &php_optind, 0, 2))!=-1) { switch (c) {
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php