zoe             Sun Apr 13 10:46:12 2008 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src/scripts/dev        generate_phpt.php 
  Log:
  Fixing: 
  (1) remove proto from start
  (2)substitute "Done" with ===DONE== after closing tag in FILE section and at 
end of EXPECTF.
  (3) Remove "add comment here..."
  
  
  
http://cvs.php.net/viewvc.cgi/php-src/scripts/dev/generate_phpt.php?r1=1.1.2.3&r2=1.1.2.4&diff_format=u
Index: php-src/scripts/dev/generate_phpt.php
diff -u php-src/scripts/dev/generate_phpt.php:1.1.2.3 
php-src/scripts/dev/generate_phpt.php:1.1.2.4
--- php-src/scripts/dev/generate_phpt.php:1.1.2.3       Thu Feb 14 10:15:44 2008
+++ php-src/scripts/dev/generate_phpt.php       Sun Apr 13 10:46:12 2008
@@ -49,7 +49,7 @@
        exit();
 }
 
-$test_info['proto'] = "proto ".$test_info['return_type']." ". 
$test_info['name']."(".$test_info['params'].")";
+$test_info['proto'] = $test_info['return_type']." ". 
$test_info['name']."(".$test_info['params'].")";
 
 
 //Set the test sections array - may want more in this later?
@@ -448,7 +448,7 @@
                        $test_case = array();
 
                        $test_case = gen_test_header($name, $proto, $desc, 
-                                     $source_file, "usage variations", " - 
<type here specifics of this variation>", $alias, $test_case);
+                                     $source_file, "usage variation","", 
$alias, $test_case);
 
                        // add variation code
                        $test_case['--FILE--'] = 
gen_variation_diff_arg_values_test($name, $arg_det, $arg_count, 
$test_case['--FILE--']);
@@ -495,10 +495,6 @@
                                        " * Alias to functions: $alias",
                                        " */",
                                        "",
-                                       "/*",
-                                       " * add a comment here to say what the 
test is supposed to do",
-                                       " */",
-                                       "",
                                        "echo \"*** Testing $fn_name() : 
$type_msg ***\\n\";",
                                        ""
                                        );
@@ -558,12 +554,12 @@
 function gen_test_trailer($test_case, $section_key = "--EXPECTF--") {
        //Complete the --FILE-- section
        array_push($test_case['--FILE--'], "");
-       array_push($test_case['--FILE--'], "echo \"Done\";", "?>");
+       array_push($test_case['--FILE--'], "?>\n===DONE===");
 
        //add a new key for the expect section
        $test_case[$section_key]=array();
        array_push($test_case[$section_key], "Expected output goes here"); 
-       array_push($test_case[$section_key], "Done"); 
+       array_push($test_case[$section_key], "===DONE==="); 
 
        return $test_case;
 }



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to