felipe Wed May 14 12:34:11 2008 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/pdo/tests pdorow.phpt
Modified files:
/php-src/ext/pdo pdo_stmt.c
Log:
- MFH: Add check for avoid segfault when trying instantiate PDORow manually
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_stmt.c?r1=1.118.2.38.2.34&r2=1.118.2.38.2.35&diff_format=u
Index: php-src/ext/pdo/pdo_stmt.c
diff -u php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.34
php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.35
--- php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.34 Tue Feb 26 00:14:04 2008
+++ php-src/ext/pdo/pdo_stmt.c Wed May 14 12:34:10 2008
@@ -18,7 +18,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pdo_stmt.c,v 1.118.2.38.2.34 2008/02/26 00:14:04 iliaa Exp $ */
+/* $Id: pdo_stmt.c,v 1.118.2.38.2.35 2008/05/14 12:34:10 felipe Exp $ */
/* The PDO Statement Handle Class */
@@ -2711,10 +2711,12 @@
void pdo_row_free_storage(pdo_stmt_t *stmt TSRMLS_DC)
{
- ZVAL_NULL(&stmt->lazy_object_ref);
-
- if (--stmt->refcount == 0) {
- free_statement(stmt TSRMLS_CC);
+ if (stmt) {
+ ZVAL_NULL(&stmt->lazy_object_ref);
+
+ if (--stmt->refcount == 0) {
+ free_statement(stmt TSRMLS_CC);
+ }
}
}
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/pdorow.phpt?view=markup&rev=1.1
Index: php-src/ext/pdo/tests/pdorow.phpt
+++ php-src/ext/pdo/tests/pdorow.phpt
--TEST--
Trying instantiate a PDORow object manually
--FILE--
<?php
new PDORow;
?>
--EXPECTF--
Fatal error: PDORow::__construct(): You should not create a PDOStatement
manually in %s on line %d
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
