On Sun, 18 May 2008, Hannes Magnusson wrote:

> On Sun, May 18, 2008 at 8:14 PM, David Soria Parra <[EMAIL PROTECTED]> wrote:
> > Hannes Magnusson wrote:
> >>
> >> This is a massive BC break...
> >> Imagine people who did if (mcrypt_enc_self_test($td) == 0) { ... }
> >> that has now changed from dealing with success to failure.
> >>
> >> I'd say rather fix the docs
> >
> > Yes I noticed that, that's why its not in 5.2. I think it's kind of 
> > "cleaning up" as mcrypt_module_self_test return a boolean too and 
> > the docs say it too. Maybe it's just in my opinion that the function 
> > itself is not that often used as it would be real issue, but if 
> > people have objections for sure we can revert that.
> The point is this is a very subtle change and not something people 
> will suspect when their applications stop working out of the blue, 
> without so much as a single warning. A function rename would be 
> obvious as it would give a fatal error, but this is a return value 
> change from false to true...

Yes, and changes should also be passed by the extension's maintainer.


PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to