[PHP-CVS] cvs: php-src(PHP_5_3) /ext/session session.c

[Dmitry Stogov]

dmitry          Tue Jun 24 06:47:45 2008 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src/ext/session        session.c 
  Log:
  Fixed memory leaks
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/session/session.c?r1=1.417.2.8.2.40.2.8&r2=1.417.2.8.2.40.2.9&diff_format=u
Index: php-src/ext/session/session.c
diff -u php-src/ext/session/session.c:1.417.2.8.2.40.2.8 
php-src/ext/session/session.c:1.417.2.8.2.40.2.9
--- php-src/ext/session/session.c:1.417.2.8.2.40.2.8    Sat Jun 21 15:27:34 2008
+++ php-src/ext/session/session.c       Tue Jun 24 06:47:45 2008
@@ -17,7 +17,7 @@
    +----------------------------------------------------------------------+
  */
 
-/* $Id: session.c,v 1.417.2.8.2.40.2.8 2008/06/21 15:27:34 felipe Exp $ */
+/* $Id: session.c,v 1.417.2.8.2.40.2.9 2008/06/24 06:47:45 dmitry Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -1497,11 +1497,13 @@
        }
        
        if (PS(session_status) != php_session_none) {
+               efree(args);
                RETURN_FALSE;
        }
        
        for (i = 0; i < 6; i++) {
                if (!zend_is_callable(*args[i], 0, &name)) {
+                       efree(args);
                        php_error_docref(NULL TSRMLS_CC, E_WARNING, "Argument 
%d is not a valid callback", i+1);
                        efree(name);
                        RETURN_FALSE;
@@ -1519,6 +1521,7 @@
                PS(mod_user_names).names[i] = *args[i];
        }
        
+       efree(args);
        RETURN_TRUE;
 }
 /* }}} */



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php