On 30.10.2008 00:02, Ilia Alshanetsky wrote:
> +#define PHP_GETTEXT_MAX_DOMAIN_LENGTH 1024
> +#define PHP_GETTEXT_DOMAIN_LENGTH_CHECK \
> +     if (domain_len > PHP_GETTEXT_MAX_DOMAIN_LENGTH) { \
> +             php_error_docref(NULL TSRMLS_CC, E_WARNING, "domain passed too 
> long"); \
> +             RETURN_FALSE; \
> +     }
> +

Is there any guarantee some weird gettext version won't crash with 
strings of <= 1024 bytes?
Is it possible to detect this size in ./configure?
Some constant, maybe?

I just want to say this thing looks like a hack to me, there should 
be a cleaner way to do this and if gettext doesn't provide it, we 
should probably notice its developers about the problem.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to