felipe Mon Nov 3 20:48:51 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/pdo_sqlite/tests debugdumpparams_001.phpt
Modified files: /php-src/ext/pdo pdo_stmt.c Log: MFH: - Fixed endless loop in PDOStatement::debugDumpParams() patch by: Jonah H. Harris <jonah.harris at gmail dot com> http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_stmt.c?r1=1.118.2.38.2.24.2.31&r2=1.118.2.38.2.24.2.32&diff_format=u Index: php-src/ext/pdo/pdo_stmt.c diff -u php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.24.2.31 php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.24.2.32 --- php-src/ext/pdo/pdo_stmt.c:1.118.2.38.2.24.2.31 Mon Nov 3 15:33:22 2008 +++ php-src/ext/pdo/pdo_stmt.c Mon Nov 3 20:48:51 2008 @@ -18,7 +18,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: pdo_stmt.c,v 1.118.2.38.2.24.2.31 2008/11/03 15:33:22 felipe Exp $ */ +/* $Id: pdo_stmt.c,v 1.118.2.38.2.24.2.32 2008/11/03 20:48:51 felipe Exp $ */ /* The PDO Statement Handle Class */ @@ -2208,6 +2208,7 @@ param->is_param, param->param_type); + zend_hash_move_forward_ex(stmt->bound_params, &pos); } } http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_sqlite/tests/debugdumpparams_001.phpt?view=markup&rev=1.1 Index: php-src/ext/pdo_sqlite/tests/debugdumpparams_001.phpt +++ php-src/ext/pdo_sqlite/tests/debugdumpparams_001.phpt --TEST-- Testing PDOStatement::debugDumpParams() with bound params --SKIPIF-- <?php if (!extension_loaded('pdo_sqlite')) print 'skip not loaded'; ?> --FILE-- <?php $db = new pdo('sqlite:memory'); $x= $db->prepare('select :a, :b'); $x->bindValue(':a', 1, PDO::PARAM_INT); $x->bindValue(':b', 'foo'); var_dump($x->debugDumpParams()); ?> --EXPECT-- SQL: [13] select :a, :b Params: 2 Key: Position #0: paramno=-1 name=[2] :a is_param=1 param_type=1 Key: Position #0: paramno=-1 name=[2] :b is_param=1 param_type=2 NULL -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php