And and Dave,

about these two tests:

On Wed, 2008-12-03 at 11:28 +0000, "Johannes Schlüter" wrote:
> johannes              Wed Dec  3 11:28:13 2008 UTC
> 
>   Modified files:              (Branch: PHP_5_3)
>     /php-src/ext/standard/tests/file  file_put_contents_variation4.phpt 
>                                       file_put_contents_variation6.phpt 
[...]
>   # I wonder we such basic tests fail and with an XFAIL a reason would be nice

This comment from my commit should read "I wonder why ..." as the tests
fail on by linux box and an have an XFAIL while testing a basic
operation (as I'd say from scanning over the code) This is a bit strange
to me...

Could you please verify the test is correct and possibly add a short
note explaining why the XFAIL is needed?

Thanks!

johannes

>   
>   
> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/file_put_contents_variation4.phpt?r1=1.1.4.2&r2=1.1.4.3&diff_format=u
> Index: php-src/ext/standard/tests/file/file_put_contents_variation4.phpt
> diff -u 
> php-src/ext/standard/tests/file/file_put_contents_variation4.phpt:1.1.4.2 
> php-src/ext/standard/tests/file/file_put_contents_variation4.phpt:1.1.4.3
> --- php-src/ext/standard/tests/file/file_put_contents_variation4.phpt:1.1.4.2 
> Wed Nov 26 10:10:17 2008
> +++ php-src/ext/standard/tests/file/file_put_contents_variation4.phpt Wed Dec 
>  3 11:28:13 2008
> @@ -42,7 +42,8 @@
>     file_put_contents($filename, "File in include path", 
> FILE_USE_INCLUDE_PATH);
>     $line = file_get_contents($firstFile);
>     echo "$line\n";
> -   unlink($firstFile);  
> +   unlink($firstFile);
> +   unlink($filename);
>  }
>  
>  ?>
> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/file_put_contents_variation6.phpt?r1=1.1.4.2&r2=1.1.4.3&diff_format=u
> Index: php-src/ext/standard/tests/file/file_put_contents_variation6.phpt
> diff -u 
> php-src/ext/standard/tests/file/file_put_contents_variation6.phpt:1.1.4.2 
> php-src/ext/standard/tests/file/file_put_contents_variation6.phpt:1.1.4.3
> --- php-src/ext/standard/tests/file/file_put_contents_variation6.phpt:1.1.4.2 
> Wed Nov 26 10:10:17 2008
> +++ php-src/ext/standard/tests/file/file_put_contents_variation6.phpt Wed Dec 
>  3 11:28:13 2008
> @@ -43,7 +43,8 @@
>     file_put_contents($filename, ". This was appended", FILE_USE_INCLUDE_PATH 
> | FILE_APPEND);  
>     $line = file_get_contents($firstFile);
>     echo "$line\n";
> -   unlink($firstFile);  
> +   unlink($firstFile); 
> +   unlink($filename); 
>  }
>  
>  ?>
> 
> 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to