On Sat, Dec 6, 2008 at 01:35, Rob Richards <[EMAIL PROTECTED]> wrote: > Hannes Magnusson wrote: >> >> On Fri, Dec 5, 2008 at 19:36, Rob Richards <[EMAIL PROTECTED]> wrote: >> >>> >>> rrichards Fri Dec 5 18:36:16 2008 UTC >>> >>> Modified files: (Branch: PHP_5_2) >>> /php-src/ext/xsl xsltprocessor.c >>> Log: >>> MFH: fix arginfo - these also accept SimpleXMLElement >>> >>> >>> http://cvs.php.net/viewvc.cgi/php-src/ext/xsl/xsltprocessor.c?r1=1.39.2.2.2.14&r2=1.39.2.2.2.15&diff_format=u >>> Index: php-src/ext/xsl/xsltprocessor.c >>> diff -u php-src/ext/xsl/xsltprocessor.c:1.39.2.2.2.14 >>> php-src/ext/xsl/xsltprocessor.c:1.39.2.2.2.15 >>> --- php-src/ext/xsl/xsltprocessor.c:1.39.2.2.2.14 Sun May 4 >>> 15:15:01 2008 >>> +++ php-src/ext/xsl/xsltprocessor.c Fri Dec 5 18:36:16 2008 >>> @@ -17,7 +17,7 @@ >>> >>> +----------------------------------------------------------------------+ >>> */ >>> >>> -/* $Id: xsltprocessor.c,v 1.39.2.2.2.14 2008/05/04 15:15:01 rrichards >>> Exp $ */ >>> +/* $Id: xsltprocessor.c,v 1.39.2.2.2.15 2008/12/05 18:36:16 rrichards >>> Exp $ */ >>> >>> #ifdef HAVE_CONFIG_H >>> #include "config.h" >>> @@ -30,23 +30,23 @@ >>> /* {{{ arginfo */ >>> static >>> ZEND_BEGIN_ARG_INFO_EX(arginfo_xsl_xsltprocessor_import_stylesheet, 0, >>> 0, 1) >>> - ZEND_ARG_OBJ_INFO(0, doc, DOMDocument, 0) >>> + ZEND_ARG_INFO(0, doc) >>> ZEND_END_ARG_INFO(); >>> >> >> Doesn't this mean E_ERROR is thrown when SimpleXML element is passed? >> If so, this commit definitely deserves a NEWS entry >> >> -Hannes >> > > As of 5.2.6, a catchable error is currently being thrown, which is > incorrect, so not sure whether or not this deserves an entry as it was > broken with the 5.2.6 release. If a regression error deserves a NEWS entry > then by all means.
Seems weird that a massive regression like this wasn't caught until 7months later, and even then not a bug report but by you... Still. It is a total wtf for anyone not using a userland error handler. I say NEWS it :) -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
