Its may break BC, but it actually fixes a bug, unless I am missing
something there is nothing special about # at the start of a .php file
that would imply by itself that this line should be skipped. I am not
suggesting we touch 5.2, but for 5.3 and beyond it makes sense to have
this fix.
Advertising
On 5-Jan-09, at 3:33 PM, Nuno Lopes wrote:
Well,.. at least it breaks BC. I think I prefer not breaking BC in
this case, as it doesn't hurt much..
Nuno
----- Original Message -----
The fact that any line starting with # was ignored is actually a
bug, the original intent (even in 5.2 where the bug also exists in
CLI) was to handle #!/path/to/executable
With the new code the check is more strict looking for # followed
by !, I think its probably the desired behavior what do you guys
think?
On 5-Jan-09, at 11:17 AM, Antony Dovgal wrote:
On 05.01.2009 19:06, Ilia Alshanetsky wrote:
Would it not be better to use :memory:, in memory DB and avoid the
file creation entirely, it'll also speed up test a bit.
Anything would do, as long as it doesn't pollute my /tmp dir.
Did you see this, btw: http://news.php.net/php.cvs/55354 ?
Ilia Alshanetsky
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
