Johannes Schlüter wrote:
> On Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote:
>   
>> Antony Dovgal wrote:
>>     
>>> On 03.02.2009 22:02, Greg Beaver wrote:
>>>   
>>>       
>>>> -          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes", sizeof(php_bz2_filter_data));
>>>> +          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes.", sizeof(php_bz2_filter_data));
>>>> -          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes", data->inbuf_len);
>>>> +          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes.", data->inbuf_len);
>>>> -          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes", data->outbuf_len);
>>>> +          php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating 
>>>> %zu bytes.", data->outbuf_len);
>>>>     
>>>>         
>>> Huh? Why add more dots?
>>>   
>>>       
>> This was in PHP_5_3, no idea why it wasn't in HEAD, but it makes syncing
>> easier if they're the same.  I don't care either way whether they have
>> periods or not, so feel free to revert if you feel strongly.
>>     
>
>
> well, with dots they look like this in the end:
>
> "Warning: Failed allocating %zu bytes. in foo.php on line 42"
>
> Which certainly looks wrong. Therefore we don't put dots in the end :-)
>
> johannes
>
>   
I really don't give a crap.  Change it if you want, I was merging
*existing* code in PHP_5_3 to HEAD, not adding new stuff.

For the record, this code was added on July 20, 2004 to bz2_filter.c.

(http://cvs.php.net/viewvc.cgi/php-src/ext/bz2/bz2_filter.c?r1=1.1&r2=1.2&pathrev=PHP_5_1&;)

The main problem appears to be that the error message clean-up in
http://cvs.php.net/viewvc.cgi/php-src/ext/bz2/bz2_filter.c?r1=1.9&r2=1.10
was never merged back to PHP 5.

I sure am glad we worked this out, can you imagine the horrors? 
Security experts would be blogging endlessly about those periods I added
back into the error messages.  What a disgrace to the language I am.  In
the future, I'll be really careful never to merge missing features back
to HEAD again, sorry about that.

Greg

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to