Pierre Joye wrote:
On Mon, May 18, 2009 at 2:07 PM, Jani Taskinen <jani.taski...@sci.fi> wrote:
Can't you do it all in one commit? Now you've littered the log with these
half-assed commits, and STILL didn't do everything..there are several
"RETURN_FALSE;"'s there where simple "return" is necessary.


I do, only missed the 2nd one... but I'm done now anyway. It is
already less painful to merge head and 5.3

You have missed 8 invalid parameters returning false parts.
Also while adding the file:// thing, you added CS violating stuff, didn't add folding tags..etc.

--Jani


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to