[PHP-CVS] cvs: php-src /win32 sendmail.c

[Kalle Sommer Nielsen]

kalle           Tue Jun 30 11:36:58 2009 UTC

  Modified files:              
    /php-src/win32      sendmail.c 
  Log:
  Fixed bug #38091 (Mail() does not use FQDN when sending SMTP helo)
  
http://cvs.php.net/viewvc.cgi/php-src/win32/sendmail.c?r1=1.70&r2=1.71&diff_format=u
Index: php-src/win32/sendmail.c
diff -u php-src/win32/sendmail.c:1.70 php-src/win32/sendmail.c:1.71
--- php-src/win32/sendmail.c:1.70       Fri Jul  6 23:06:51 2007
+++ php-src/win32/sendmail.c    Tue Jun 30 11:36:58 2009
@@ -17,7 +17,7 @@
  *
  */
 
-/* $Id: sendmail.c,v 1.70 2007/07/06 23:06:51 dmitry Exp $ */
+/* $Id: sendmail.c,v 1.71 2009/06/30 11:36:58 kalle Exp $ */
 
 #include "php.h"                               /*php specific */
 #include <stdio.h>
@@ -37,6 +37,7 @@
 #endif /* NETWARE */
 #include "sendmail.h"
 #include "php_ini.h"
+#include "inet.h"
 
 #if HAVE_PCRE || HAVE_BUNDLED_PCRE
 #include "ext/pcre/php_pcre.h"
@@ -765,16 +766,52 @@
 static int MailConnect()
 {
 
-       int res;
+       int res, namelen;
        short portnum;
+       struct hostent *ent;
+       IN_ADDR addr;
+#ifdef HAVE_IPV6
+       IN6_ADDR addr6;
+#endif
 
        /* Create Socket */
-       if ((sc = socket(PF_INET, SOCK_STREAM, 0)) == INVALID_SOCKET)
+       if ((sc = socket(PF_INET, SOCK_STREAM, 0)) == INVALID_SOCKET) {
                return (FAILED_TO_OBTAIN_SOCKET_HANDLE);
+       }
 
        /* Get our own host name */
-       if (gethostname(LocalHost, HOST_NAME_LEN))
+       if (gethostname(LocalHost, HOST_NAME_LEN)) {
+               return (FAILED_TO_GET_HOSTNAME);
+       }
+
+       ent = gethostbyname(LocalHost);
+
+       if (!ent) {
                return (FAILED_TO_GET_HOSTNAME);
+       }
+
+       namelen = strlen(ent->h_name);
+
+#ifdef HAVE_IPV6
+       if (inet_pton(AF_INET, ent->h_name, &addr) == 1 || inet_pton(AF_INET6, 
ent->h_name, &addr6) == 1)
+#else
+       if (inet_pton(AF_INET, ent->h_name, &addr) == 1)
+#endif
+       {
+               if (namelen + 2 >= HOST_NAME_LEN) {
+                       return (FAILED_TO_GET_HOSTNAME);
+               }
+
+               strcpy(LocalHost, "[");
+               strcpy(LocalHost + 1, ent->h_name);
+               strcpy(LocalHost + namelen + 1, "]");
+       } else {
+               if (namelen >= HOST_NAME_LEN) {
+                       return (FAILED_TO_GET_HOSTNAME);
+               }
+
+               strcpy(LocalHost, ent->h_name);
+       }
 
        /* Resolve the servers IP */
        /*
@@ -794,8 +831,9 @@
        sock_in.sin_port = htons(portnum);
        sock_in.sin_addr.S_un.S_addr = GetAddr(MailHost);
 
-       if (connect(sc, (LPSOCKADDR) & sock_in, sizeof(sock_in)))
+       if (connect(sc, (LPSOCKADDR) & sock_in, sizeof(sock_in))) {
                return (FAILED_TO_CONNECT);
+       }
 
        /* receive Server welcome message */
        res = Ack(NULL);



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php