uw Mon, 21 Sep 2009 12:02:30 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=288523
Log:
Fixing test by calling it a known limit. We keept the test failing as a
reminder to think about how to handle BIT(32) and up but none of us has an
idea. Thinks work fine up to BIT(31) - the limitation should be documented.
Changed paths:
U php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
U php/php-src/trunk/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
Modified:
php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
2009-09-21 11:54:15 UTC (rev 288522)
+++ php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
2009-09-21 12:02:30 UTC (rev 288523)
@@ -22,7 +22,8 @@
printf("[001] Cannot connect to the server using host=%s,
user=%s, passwd=***, dbname=%s, port=%s, socket=%s\n",
$host, $user, $db, $port, $socket);
- for ($bits = 1; $bits < 64; $bits++) {
+ /* NOTE: works only for up to 31 bits! This limitation should be
documented. */
+ for ($bits = 1; $bits < 32; $bits++) {
$max_value = pow(2, $bits) - 1;
$tests = 0;
if (!mysqli_query($link, "DROP TABLE IF EXISTS test") ||
Modified: php/php-src/trunk/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
===================================================================
--- php/php-src/trunk/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
2009-09-21 11:54:15 UTC (rev 288522)
+++ php/php-src/trunk/ext/mysqli/tests/mysqli_stmt_fetch_bit.phpt
2009-09-21 12:02:30 UTC (rev 288523)
@@ -22,7 +22,8 @@
printf("[001] Cannot connect to the server using host=%s,
user=%s, passwd=***, dbname=%s, port=%s, socket=%s\n",
$host, $user, $db, $port, $socket);
- for ($bits = 1; $bits < 64; $bits++) {
+ /* NOTE: works only for up to 31 bits! This limitation should be
documented. */
+ for ($bits = 1; $bits < 32; $bits++) {
$max_value = pow(2, $bits) - 1;
$tests = 0;
if (!mysqli_query($link, "DROP TABLE IF EXISTS test") ||
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
