Are all the date_sun* tests supposed to fail? They failed after the first fix as well..

--Jani


Rasmus Lerdorf wrote:
rasmus                                   Sat, 26 Sep 2009 00:53:59 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=288834

Log:
Refix bug #49558 as per bug #49676

Bugs: http://bugs.php.net/49558 (Closed) Sunrise Problems around 91 degree 
zenith
      http://bugs.php.net/49676 (Closed) date_sunrise() off by several minutes
Changed paths:
    U   php/php-src/branches/PHP_5_2/ext/date/php_date.c
    U   php/php-src/branches/PHP_5_3/ext/date/php_date.c
    U   php/php-src/trunk/ext/date/php_date.c

Modified: php/php-src/branches/PHP_5_2/ext/date/php_date.c
===================================================================
--- php/php-src/branches/PHP_5_2/ext/date/php_date.c    2009-09-26 00:40:56 UTC 
(rev 288833)
+++ php/php-src/branches/PHP_5_2/ext/date/php_date.c    2009-09-26 00:53:59 UTC 
(rev 288834)
@@ -2456,7 +2456,7 @@
        }

        timelib_unixtime2local(t, time);
-       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, calc_sunset?0:1, 
&h_rise, &h_set, &rise, &set, &transit);
+       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, 1, &h_rise, 
&h_set, &rise, &set, &transit);
        timelib_time_dtor(t);

        if (rs != 0) {

Modified: php/php-src/branches/PHP_5_3/ext/date/php_date.c
===================================================================
--- php/php-src/branches/PHP_5_3/ext/date/php_date.c    2009-09-26 00:40:56 UTC 
(rev 288833)
+++ php/php-src/branches/PHP_5_3/ext/date/php_date.c    2009-09-26 00:53:59 UTC 
(rev 288834)
@@ -3927,7 +3927,7 @@
        }

        timelib_unixtime2local(t, time);
-       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, calc_sunset?0:1, 
&h_rise, &h_set, &rise, &set, &transit);
+       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, 1, &h_rise, 
&h_set, &rise, &set, &transit);
        timelib_time_dtor(t);

        if (rs != 0) {

Modified: php/php-src/trunk/ext/date/php_date.c
===================================================================
--- php/php-src/trunk/ext/date/php_date.c       2009-09-26 00:40:56 UTC (rev 
288833)
+++ php/php-src/trunk/ext/date/php_date.c       2009-09-26 00:53:59 UTC (rev 
288834)
@@ -4049,7 +4049,7 @@
        }

        timelib_unixtime2local(t, time);
-       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, calc_sunset?0:1, 
&h_rise, &h_set, &rise, &set, &transit);
+       rs = timelib_astro_rise_set_altitude(t, longitude, latitude, altitude, 1, &h_rise, 
&h_set, &rise, &set, &transit);
        timelib_time_dtor(t);

        if (rs != 0) {




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to