uw                                       Tue, 20 Oct 2009 14:11:43 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=289798

Log:
libmysql is still 'buggy' - skip test with libmysql

Changed paths:
    U   
php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
    U   php/php-src/trunk/ext/mysqli/tests/mysqli_change_user_insert_id.phpt

Modified: 
php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
===================================================================
--- 
php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_change_user_insert_id.phpt 
    2009-10-20 13:58:57 UTC (rev 289797)
+++ 
php/php-src/branches/PHP_5_3/ext/mysqli/tests/mysqli_change_user_insert_id.phpt 
    2009-10-20 14:11:43 UTC (rev 289798)
@@ -6,13 +6,16 @@
 require_once('skipifemb.inc');
 require_once('skipifconnectfailure.inc');
 require_once('connect.inc');
+
 if (!$IS_MYSQLND) {
        if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, 
$socket))
                die("skip Can't test server version, might hit known bugs 
http://bugs.mysql.com/bug.php?id=30472, 
http://bugs.mysql.com/bug.php?id=45184";);
-       if (mysqli_get_client_version($link) <= 50135)
-               /* TODO - check wich version got the patch */
+
+       if ((mysqli_get_client_version($link) <= 50139) || 
(mysqli_get_server_version($link) <= 50139))
+               /* #30472 got fixed in 5.1.23 but #45184 is open */
                die(sprintf("skip libmysql %s should have bugs 
http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184";,
         mysqli_get_client_version($link)));
+
        mysqli_close($link);
 }
 ?>

Modified: php/php-src/trunk/ext/mysqli/tests/mysqli_change_user_insert_id.phpt
===================================================================
--- php/php-src/trunk/ext/mysqli/tests/mysqli_change_user_insert_id.phpt        
2009-10-20 13:58:57 UTC (rev 289797)
+++ php/php-src/trunk/ext/mysqli/tests/mysqli_change_user_insert_id.phpt        
2009-10-20 14:11:43 UTC (rev 289798)
@@ -6,13 +6,16 @@
 require_once('skipifemb.inc');
 require_once('skipifconnectfailure.inc');
 require_once('connect.inc');
+
 if (!$IS_MYSQLND) {
        if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, 
$socket))
                die("skip Can't test server version, might hit known bugs 
http://bugs.mysql.com/bug.php?id=30472, 
http://bugs.mysql.com/bug.php?id=45184";);
-       if (mysqli_get_client_version($link) <= 50135)
-               /* TODO - check wich version got the patch */
+
+       if ((mysqli_get_client_version($link) <= 50139) || 
(mysqli_get_server_version($link) <= 50139))
+               /* #30472 got fixed in 5.1.23 but #45184 is open */
                die(sprintf("skip libmysql %s should have bugs 
http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184";,
         mysqli_get_client_version($link)));
+
        mysqli_close($link);
 }
 ?>

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to