sixd Fri, 06 Nov 2009 02:09:47 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=290364
Log: Add pecl mail list Changed paths: U php/php-src/branches/PHP_5_3/README.SUBMITTING_PATCH U php/php-src/trunk/README.SUBMITTING_PATCH
Modified: php/php-src/branches/PHP_5_3/README.SUBMITTING_PATCH =================================================================== --- php/php-src/branches/PHP_5_3/README.SUBMITTING_PATCH 2009-11-05 23:03:28 UTC (rev 290363) +++ php/php-src/branches/PHP_5_3/README.SUBMITTING_PATCH 2009-11-06 02:09:47 UTC (rev 290364) @@ -12,17 +12,20 @@ the patch progress and prevent your changes getting lost in the PHP mail archives. -If your code change is large then discuss it with the extension -maintainer and/or intern...@lists.php.net (or pear-...@lists.php.net -if you are patching PEAR) before starting work. Maintainers can be -found in the EXTENSIONS file in the PHP source. Mail list subscription -is explained on http://www.php.net/mailing-lists.php +If your code change is large then first discuss it with the extension +maintainer and/or a development mail list. Extension maintainers can +be found in the EXTENSIONS file in the PHP source. Use the +intern...@lists.php.net mail list to discuss changes to the base PHP +code. Use pecl-...@lists.php.net for changes to code that is only +available from PECL (http://pecl.php.net/). Use pear-...@lists.php.net +for PEAR modules (http://pear.php.net/). Mail list subscription is +explained on http://www.php.net/mailing-lists.php. -If your patch affects user-functionality or makes significant internal -changes to PHP then create a simple RFC on http://wiki.php.net/rfc. -This RFC can be used for initial discussion and later for -documentation. Wiki accounts can be requested on -http://wiki.php.net/start?do=register +If a PHP or PECL patch affects user-functionality or makes significant +internal changes then create a simple RFC on http://wiki.php.net/rfc +before starting discussion. This RFC can be used for initial +discussion and later for documentation. Wiki accounts can be requested +on http://wiki.php.net/start?do=register How to create your patch @@ -39,12 +42,12 @@ Read CODING_STANDARDS before you start working. After modifying the source see README.TESTING and -http://qa.php.net/write-test.php for how to test your -change. Submitting test scripts helps us to understand what -functionality has changed. It is important for the stability and -maintainability of PHP that tests are comprehensive. +http://qa.php.net/write-test.php for how to test. Submitting test +scripts helps us to understand what functionality has changed. It is +important for the stability and maintainability of PHP that tests are +comprehensive. -After testing is finished, create a diff file using the command: +After testing is finished, create a patch file using the command: svn diff > your_patch.txt @@ -54,8 +57,8 @@ Checklist for submitting your patch ----------------------------------- - - Update SVN source just before creating your final 'diff' and - running tests. + - Update SVN source just before running your final 'diff' and + before testing. - Run "make test" to check your patch doesn't break other features. - Rebuild PHP with --enable-debug (which will show some kinds of memory errors) and check the PHP and web server error logs after @@ -69,25 +72,30 @@ Where to send your patch ------------------------ -If you are patching C source then email the patch to -intern...@lists.php.net and/or to the extension maintainer (see -EXTENSIONS). +If you are patching PHP C source then email the patch to +intern...@lists.php.net -If you are patching PEAR then send the patch to pear-...@lists.php.net. +If you patching a PECL extension then send the patch to +pecl-...@lists.php.net -Please make the subject prefix "[PATCH]". +If you are patching PEAR then send the patch to +pear-...@lists.php.net -Include the patch as a attachment. Note: only MIME attachments of type -'text/*' are accepted. The easiest way to accomplish this is to make -the file extension '.txt'. +The mail can be CC'd to the extension maintainer (see EXTENSIONS). +Please make the subject prefix "[PATCH]". + +Include the patch as an attachment. Note: only MIME attachments of +type 'text/*' are accepted. The easiest way to accomplish this is to +make the file extension '.txt'. + Explain what has been fixed/added/changed by your patch. Test scripts should be included in the email. Include the bug id(s) which can be closed by your patch. -Finally, if there is a bug open, add a link in the bug report to the -source of your patch. +Finally, update any open bugs and add a link to the source of your +patch. What happens after you submit your patch Modified: php/php-src/trunk/README.SUBMITTING_PATCH =================================================================== --- php/php-src/trunk/README.SUBMITTING_PATCH 2009-11-05 23:03:28 UTC (rev 290363) +++ php/php-src/trunk/README.SUBMITTING_PATCH 2009-11-06 02:09:47 UTC (rev 290364) @@ -12,17 +12,20 @@ the patch progress and prevent your changes getting lost in the PHP mail archives. -If your code change is large then discuss it with the extension -maintainer and/or intern...@lists.php.net (or pear-...@lists.php.net -if you are patching PEAR) before starting work. Maintainers can be -found in the EXTENSIONS file in the PHP source. Mail list subscription -is explained on http://www.php.net/mailing-lists.php +If your code change is large then first discuss it with the extension +maintainer and/or a development mail list. Extension maintainers can +be found in the EXTENSIONS file in the PHP source. Use the +intern...@lists.php.net mail list to discuss changes to the base PHP +code. Use pecl-...@lists.php.net for changes to code that is only +available from PECL (http://pecl.php.net/). Use pear-...@lists.php.net +for PEAR modules (http://pear.php.net/). Mail list subscription is +explained on http://www.php.net/mailing-lists.php. -If your patch affects user-functionality or makes significant internal -changes to PHP then create a simple RFC on http://wiki.php.net/rfc. -This RFC can be used for initial discussion and later for -documentation. Wiki accounts can be requested on -http://wiki.php.net/start?do=register +If a PHP or PECL patch affects user-functionality or makes significant +internal changes then create a simple RFC on http://wiki.php.net/rfc +before starting discussion. This RFC can be used for initial +discussion and later for documentation. Wiki accounts can be requested +on http://wiki.php.net/start?do=register How to create your patch @@ -39,12 +42,12 @@ Read CODING_STANDARDS before you start working. After modifying the source see README.TESTING and -http://qa.php.net/write-test.php for how to test your -change. Submitting test scripts helps us to understand what -functionality has changed. It is important for the stability and -maintainability of PHP that tests are comprehensive. +http://qa.php.net/write-test.php for how to test. Submitting test +scripts helps us to understand what functionality has changed. It is +important for the stability and maintainability of PHP that tests are +comprehensive. -After testing is finished, create a diff file using the command: +After testing is finished, create a patch file using the command: svn diff > your_patch.txt @@ -54,8 +57,8 @@ Checklist for submitting your patch ----------------------------------- - - Update SVN source just before creating your final 'diff' and - running tests. + - Update SVN source just before running your final 'diff' and + before testing. - Run "make test" to check your patch doesn't break other features. - Rebuild PHP with --enable-debug (which will show some kinds of memory errors) and check the PHP and web server error logs after @@ -69,25 +72,30 @@ Where to send your patch ------------------------ -If you are patching C source then email the patch to -intern...@lists.php.net and/or to the extension maintainer (see -EXTENSIONS). +If you are patching PHP C source then email the patch to +intern...@lists.php.net -If you are patching PEAR then send the patch to pear-...@lists.php.net. +If you patching a PECL extension then send the patch to +pecl-...@lists.php.net -Please make the subject prefix "[PATCH]". +If you are patching PEAR then send the patch to +pear-...@lists.php.net -Include the patch as a attachment. Note: only MIME attachments of type -'text/*' are accepted. The easiest way to accomplish this is to make -the file extension '.txt'. +The mail can be CC'd to the extension maintainer (see EXTENSIONS). +Please make the subject prefix "[PATCH]". + +Include the patch as an attachment. Note: only MIME attachments of +type 'text/*' are accepted. The easiest way to accomplish this is to +make the file extension '.txt'. + Explain what has been fixed/added/changed by your patch. Test scripts should be included in the email. Include the bug id(s) which can be closed by your patch. -Finally, if there is a bug open, add a link in the bug report to the -source of your patch. +Finally, update any open bugs and add a link to the source of your +patch. What happens after you submit your patch
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php